MNT: standardize pluralization of private names in 3D Collections

tacaswell · tacaswell · commit 23fd7ce2c411 · 2020-11-10T17:30:32.000-05:00
diff --git a/lib/mpl_toolkits/mplot3d/art3d.py b/lib/mpl_toolkits/mplot3d/art3d.py
@@ -458,12 +458,12 @@ def set_depthshade(self, depthshade):
     def set_facecolor(self, c):
         # docstring inherited
         super().set_facecolor(c)
-        self._facecolor3d = self.get_facecolor()
+        self._facecolors3d = self.get_facecolor()
 
     def set_edgecolor(self, c):
         # docstring inherited
         super().set_edgecolor(c)
-        self._edgecolor3d = self.get_edgecolor()
+        self._edgecolors3d = self.get_edgecolor()
 
     def set_sort_zpos(self, val):
         """Set the position to use for z-sorting."""
@@ -481,8 +481,8 @@ def set_3d_properties(self, zs, zdir):
             xs = []
             ys = []
         self._offsets3d = juggle_axes(xs, ys, np.atleast_1d(zs), zdir)
-        self._facecolor3d = self.get_facecolor()
-        self._edgecolor3d = self.get_edgecolor()
+        self._facecolors3d = self.get_facecolor()
+        self._edgecolors3d = self.get_edgecolor()
         self.stale = True
 
     @cbook._delete_parameter('3.4', 'renderer')
@@ -492,13 +492,13 @@ def do_3d_projection(self, renderer=None):
         vxs, vys, vzs, vis = proj3d.proj_transform_clip(xs, ys, zs,
                                                         self.axes.M)
 
-        fcs = (_zalpha(self._facecolor3d, vzs) if self._depthshade else
-               self._facecolor3d)
+        fcs = (_zalpha(self._facecolors3d, vzs) if self._depthshade else
+               self._facecolors3d)
         fcs = mcolors.to_rgba_array(fcs, self._alpha)
         super().set_facecolor(fcs)
 
-        ecs = (_zalpha(self._edgecolor3d, vzs) if self._depthshade else
-               self._edgecolor3d)
+        ecs = (_zalpha(self._edgecolors3d, vzs) if self._depthshade else
+               self._edgecolors3d)
         ecs = mcolors.to_rgba_array(ecs, self._alpha)
         super().set_edgecolor(ecs)
         super().set_offsets(np.column_stack([vxs, vys]))
@@ -550,8 +550,8 @@ def set_3d_properties(self, zs, zdir):
             xs = []
             ys = []
         self._offsets3d = juggle_axes(xs, ys, np.atleast_1d(zs), zdir)
-        self._facecolor3d = self.get_facecolor()
-        self._edgecolor3d = self.get_edgecolor()
+        self._facecolors3d = self.get_facecolor()
+        self._edgecolors3d = self.get_edgecolor()
         self._sizes3d = self.get_sizes()
         self._linewidth3d = self.get_linewidth()
         self.stale = True
@@ -575,12 +575,12 @@ def set_depthshade(self, depthshade):
     def set_facecolor(self, c):
         # docstring inherited
         super().set_facecolor(c)
-        self._facecolor3d = self.get_facecolor()
+        self._facecolors3d = self.get_facecolor()
 
     def set_edgecolor(self, c):
         # docstring inherited
         super().set_edgecolor(c)
-        self._edgecolor3d = self.get_edgecolor()
+        self._edgecolors3d = self.get_edgecolor()
 
     def set_sizes(self, sizes, dpi=72.0):
         # docstring inherited
@@ -599,10 +599,10 @@ def do_3d_projection(self, renderer=None):
         vxs, vys, vzs, vis = proj3d.proj_transform_clip(xs, ys, zs,
                                                         self.axes.M)
 
-        fcs = (_zalpha(self._facecolor3d, vzs) if self._depthshade else
-               self._facecolor3d)
-        ecs = (_zalpha(self._edgecolor3d, vzs) if self._depthshade else
-               self._edgecolor3d)
+        fcs = (_zalpha(self._facecolors3d, vzs) if self._depthshade else
+               self._facecolors3d)
+        ecs = (_zalpha(self._edgecolors3d, vzs) if self._depthshade else
+               self._edgecolors3d)
         sizes = self._sizes3d
         lws = self._linewidth3d
 
@@ -646,9 +646,9 @@ def _update_scalarmappable(sm):
     ret = sm.update_scalarmappable()
     if copy_state:
         if sm._is_filled:
-            sm._facecolor3d = sm._facecolors
+            sm._facecolors3d = sm._facecolors
         elif sm._is_stroked:
-            sm._edgecolor3d = sm._edgecolors
+            sm._edgecolors3d = sm._edgecolors
 
 
 def patch_collection_2d_to_3d(col, zs=0, zdir='z', depthshade=True):
