Merge pull request #2679 from tacaswell/fix_animation_tests

pelson · pelson · commit 263c1b97d873 · 2013-12-20T03:18:03.000-08:00
Make `test_save_animation_smoketest` actually run
diff --git a/.travis.yml b/.travis.yml
@@ -18,7 +18,7 @@ python:
 
 install:
   - pip install -q --use-mirrors nose python-dateutil numpy pep8 pyparsing pillow
-  - sudo apt-get update && sudo apt-get -qq install inkscape
+  - sudo apt-get update && sudo apt-get -qq install inkscape libav-tools
   - python setup.py install
 
 script:
diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
@@ -1296,6 +1296,7 @@ def tk_window_focus():
 
 default_test_modules = [
     'matplotlib.tests.test_agg',
+    'matplotlib.tests.test_animation',
     'matplotlib.tests.test_arrow_patches',
     'matplotlib.tests.test_artist',
     'matplotlib.tests.test_axes',
diff --git a/lib/matplotlib/tests/test_animation.py b/lib/matplotlib/tests/test_animation.py
@@ -3,15 +3,14 @@
 
 import six
 
-import os
 import tempfile
 
 import numpy as np
-
+from nose import with_setup
 from matplotlib import pyplot as plt
 from matplotlib import animation
 from matplotlib.testing.noseclasses import KnownFailureTest
-from matplotlib.testing.decorators import cleanup
+from matplotlib.testing.decorators import CleanupTest
 
 
 WRITER_OUTPUT = dict(ffmpeg='mp4', ffmpeg_file='mp4',
@@ -23,16 +22,18 @@
 # Smoke test for saving animations.  In the future, we should probably
 # design more sophisticated tests which compare resulting frames a-la
 # matplotlib.testing.image_comparison
-@cleanup
 def test_save_animation_smoketest():
     for writer, extension in six.iteritems(WRITER_OUTPUT):
         yield check_save_animation, writer, extension
 
 
+@with_setup(CleanupTest.setup_class, CleanupTest.teardown_class)
 def check_save_animation(writer, extension='mp4'):
     if not animation.writers.is_available(writer):
         raise KnownFailureTest("writer '%s' not available on this system"
                                % writer)
+    if 'mencoder' in writer:
+        raise KnownFailureTest("mencoder is broken")
     fig, ax = plt.subplots()
     line, = ax.plot([], [])
 
@@ -49,7 +50,12 @@ def animate(i):
     # Use NamedTemporaryFile: will be automatically deleted
     F = tempfile.NamedTemporaryFile(suffix='.' + extension)
     anim = animation.FuncAnimation(fig, animate, init_func=init, frames=5)
-    anim.save(F.name, fps=30, writer=writer)
+    try:
+        anim.save(F.name, fps=30, writer=writer)
+    except UnicodeDecodeError:
+        raise KnownFailureTest("There can be errors in the numpy " +
+                               "import stack, " +
+                               "see issues #1891 and #2679")
 
 
 if __name__ == "__main__":
