Skip to content

Commit 26d8091

Browse files
authored
Merge pull request #16000 from timhoffm/dedeprecate-xmin_xmax-3d
De-deprecate *min/*max parameters to set_x/y/zlim()
2 parents cd41774 + 3b90b1e commit 26d8091

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

doc/api/next_api_changes/deprecations.rst

+6
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,9 @@ This attribute is unused and deprecated.
6767
``widgets.TextBox.params_to_disable``
6868
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
6969
This attribute is deprecated.
70+
71+
Revert deprecation \*min, \*max keyword arguments to ``set_x/y/zlim_3d()``
72+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
73+
These keyword arguments were deprecated in 3.0, alongside with the respective
74+
parameters in ``set_xlim()`` / ``set_ylim()``. The deprecations of the 2D
75+
versions were already reverted in in 3.1.

lib/mpl_toolkits/mplot3d/axes3d.py

-12
Original file line numberDiff line numberDiff line change
@@ -578,14 +578,10 @@ def set_xlim3d(self, left=None, right=None, emit=True, auto=False,
578578
if right is None and np.iterable(left):
579579
left, right = left
580580
if xmin is not None:
581-
cbook.warn_deprecated('3.0', name='`xmin`',
582-
alternative='`left`', obj_type='argument')
583581
if left is not None:
584582
raise TypeError('Cannot pass both `xmin` and `left`')
585583
left = xmin
586584
if xmax is not None:
587-
cbook.warn_deprecated('3.0', name='`xmax`',
588-
alternative='`right`', obj_type='argument')
589585
if right is not None:
590586
raise TypeError('Cannot pass both `xmax` and `right`')
591587
right = xmax
@@ -636,14 +632,10 @@ def set_ylim3d(self, bottom=None, top=None, emit=True, auto=False,
636632
if top is None and np.iterable(bottom):
637633
bottom, top = bottom
638634
if ymin is not None:
639-
cbook.warn_deprecated('3.0', name='`ymin`',
640-
alternative='`bottom`', obj_type='argument')
641635
if bottom is not None:
642636
raise TypeError('Cannot pass both `ymin` and `bottom`')
643637
bottom = ymin
644638
if ymax is not None:
645-
cbook.warn_deprecated('3.0', name='`ymax`',
646-
alternative='`top`', obj_type='argument')
647639
if top is not None:
648640
raise TypeError('Cannot pass both `ymax` and `top`')
649641
top = ymax
@@ -695,14 +687,10 @@ def set_zlim3d(self, bottom=None, top=None, emit=True, auto=False,
695687
if top is None and np.iterable(bottom):
696688
bottom, top = bottom
697689
if zmin is not None:
698-
cbook.warn_deprecated('3.0', name='`zmin`',
699-
alternative='`bottom`', obj_type='argument')
700690
if bottom is not None:
701691
raise TypeError('Cannot pass both `zmin` and `bottom`')
702692
bottom = zmin
703693
if zmax is not None:
704-
cbook.warn_deprecated('3.0', name='`zmax`',
705-
alternative='`top`', obj_type='argument')
706694
if top is not None:
707695
raise TypeError('Cannot pass both `zmax` and `top`')
708696
top = zmax

0 commit comments

Comments
 (0)