ENH: Responded to review comments:

madphysicist · madphysicist · commit 2e8c8249daf4 · 2017-02-16T16:40:33.000-05:00
Changed default inputs in example transformer class
Removed level of nesting in initializer of said class
Moved out one test into a separate method
diff --git a/examples/ticks_and_spines/tick_transform_formatter.py b/examples/ticks_and_spines/tick_transform_formatter.py
@@ -34,7 +34,7 @@ class LinearTransform:
     a linear transformation.
     """
 
-    def __init__(self, in_start=None, in_end=None, out_start=None, out_end=None):
+    def __init__(self, in_start=0.0, in_end=None, out_start=0.0, out_end=None):
         """
         Sets up the transformation such that `in_start` gets mapped to
         `out_start` and `in_end` gets mapped to `out_end`. The following
@@ -56,24 +56,19 @@ def __init__(self, in_start=None, in_end=None, out_start=None, out_end=None):
           - both ends are missing: set ranges to 1.0
           - one end is missing: set it to the other end
         """
-        self._in_offset = 0.0 if in_start is None else in_start
-        self._out_offset = 0.0 if out_start is None else out_start
-
-        if in_end is None:
-            if out_end is None:
-                self._in_scale = 1.0
-            else:
-                self._in_scale = out_end - self._in_offset
-        else:
+        if in_end is not None:
             self._in_scale = in_end - self._in_offset
-
-        if out_end is None:
-            if in_end is None:
-                self._out_scale = 1.0
-            else:
-                self._out_scale = in_end - self._out_offset
+        elif out_end is None:
+            self._in_scale = 1.0
         else:
+            self._in_scale = out_end - self._in_offset
+
+        if out_end not is None:
             self._out_scale = out_end - self._out_offset
+        elif in_end is None:
+            self._out_scale = 1.0
+        else:
+            self._out_scale = in_end - self._out_offset
 
     def __call__(self, x):
         """
@@ -92,8 +87,7 @@ def __call__(self, x):
 if counts.min() < 0:
     counts += counts.min()
 
-fig = plt.figure()
-ax1 = fig.add_subplot(111)
+fig, ax1 = plt.subplots()
 ax2 = fig.add_subplot(111, sharex=ax1, sharey=ax1, frameon=False)
 
 ax1.plot(temp_C, counts, drawstyle='steps-mid')
diff --git a/lib/matplotlib/tests/test_ticker.py b/lib/matplotlib/tests/test_ticker.py
@@ -719,9 +719,10 @@ def test_set_locs(self, fmt):
         assert fmt.locs == locs
         assert fmt.formatter.locs == xlocs
 
-        fmt.set_locs(None)
-        assert fmt.locs is None
-        assert fmt.formatter.locs is None
+    def test_clear_locs(self, loc_fmt):
+        loc_fmt.set_locs(None)
+        assert loc_fmt.locs is None
+        assert loc_fmt.formatter.locs is None
 
     def test_fix_minus(self, fmt):
         val = '-19.0'
