cleanup _plot_args_replacer logic

timhoffm · timhoffm · commit 31dbef650fbe · 2018-03-31T14:01:46.000+02:00
diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
@@ -1529,6 +1529,9 @@ def _replacer(data, key):
     following arguments are replaced by **data[<arg>]**:
 
     {replaced}
+    
+    Objects passed as **data** must support item access (``data[<arg>]``) and 
+    membership test (``<arg> in data``).
 """
 
 
@@ -1554,7 +1557,7 @@ def _add_data_doc(docstring, replace_names, replace_all_args):
     if docstring is None:
         docstring = ''
     else:
-        docstring = dedent(docstring)
+        docstring = dedent(docstring)git
     _repl = ""
     if replace_names is None:
         _repl = "* All positional and all keyword arguments."
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -44,18 +44,24 @@
 rcParams = matplotlib.rcParams
 
 
+def _has_item(data, name):
+    """Return whether *data* can be item-accessed with *name*.
+
+    This supports data with a dict-like interface (`in` checks item
+    availability) and with numpy.arrays.
+    """
+    try:
+        return name in data or name in data.dtype.names
+    except (AttributeError, TypeError):
+        return False
+
+
 def _plot_args_replacer(args, data):
     if len(args) == 1:
         return ["y"]
     elif len(args) == 2:
         # this can be two cases: x,y or y,c
-        if (not args[1] in data and
-            not (hasattr(data, 'dtype') and
-                 hasattr(data.dtype, 'names') and
-                 data.dtype.names is not None and
-                 args[1] in data.dtype.names)):
-            # this is not in data, so just assume that it is something which
-            # will not get replaced (color spec or array like).
+        if not _has_item(data, args[1]):
             return ["y", "c"]
         # it's data, but could be a color code like 'ro' or 'b--'
         # -> warn the user in that case...
