mypy: Warn about unreachable code

QuLogic · QuLogic · commit 34d80c359ba0 · 2024-02-15T20:58:04.000-05:00
And also fix some types to fix those warnings.
diff --git a/lib/matplotlib/_type1font.py b/lib/matplotlib/_type1font.py
@@ -21,12 +21,15 @@
   v1.1, 1993. ISBN 0-201-57044-0.
 """
 
+from __future__ import annotations
+
 import binascii
 import functools
 import logging
 import re
 import string
 import struct
+import typing as T
 
 import numpy as np
 
@@ -171,7 +174,7 @@ def value(self):
             return float(self.raw)
 
 
-def _tokenize(data: bytes, skip_ws: bool):
+def _tokenize(data: bytes, skip_ws: bool) -> T.Generator[_Token, int, None]:
     """
     A generator that produces _Token instances from Type-1 font code.
 
@@ -194,7 +197,7 @@ def _tokenize(data: bytes, skip_ws: bool):
     hex_re = re.compile(r'^<[0-9a-fA-F\0\t\r\f\n ]*>$')
     oct_re = re.compile(r'[0-7]{1,3}')
     pos = 0
-    next_binary = None
+    next_binary: int | None = None
 
     while pos < len(text):
         if next_binary is not None:
diff --git a/pyproject.toml b/pyproject.toml
@@ -227,6 +227,7 @@ exclude = [
   # stubtest will import and run, opening a figure if not excluded
   ".*/tinypages"
 ]
+warn_unreachable = true
 
 [tool.rstcheck]
 ignore_directives = [

Original file line number	Diff line number	Diff line change
`@@ -227,6 +227,7 @@ exclude = [`
`227`	`227`	`# stubtest will import and run, opening a figure if not excluded`
`228`	`228`	`".*/tinypages"`
`229`	`229`	`]`
	`230`	`+warn_unreachable = true`
`230`	`231`
`231`	`232`	`[tool.rstcheck]`
`232`	`233`	`ignore_directives = [`