Skip to content

Commit 377ff54

Browse files
committed
eliminating repeated loop
1 parent 78513d2 commit 377ff54

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

lib/matplotlib/backend_bases.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -3292,9 +3292,12 @@ def mpl_connect(self, s, func):
32923292
- 'tool_message_event'
32933293
- 'tool_removed_event'
32943294
- 'tool_added_event'
3295+
32953296
For every tool added a new event is created
3296-
- 'tool_trigger_TOOLNAME
3297-
Where TOOLNAME is the id of the tool.
3297+
3298+
- 'tool_trigger_TOOLNAME`
3299+
Where TOOLNAME is the id of the tool.
3300+
32983301
func : function
32993302
Function to be called with signature
33003303
def func(event)
@@ -3347,8 +3350,7 @@ def get_tool_keymap(self, name):
33473350
return keys
33483351

33493352
def _remove_keys(self, name):
3350-
keys = [k for k, v in six.iteritems(self._keys) if v == name]
3351-
for k in keys:
3353+
for k in self.get_tool_keymap(name):
33523354
del self._keys[k]
33533355

33543356
def set_tool_keymap(self, name, *keys):

lib/matplotlib/backend_tools.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ def __init__(self, *args, **kwargs):
244244
'motion_notify_event', self.send_message)
245245

246246
def send_message(self, event):
247-
"""Call `matplotlib.backend_bases.NavigationBase.message_event"""
247+
"""Call `matplotlib.backend_bases.NavigationBase.message_event`"""
248248
if self.navigation.messagelock.locked():
249249
return
250250

lib/matplotlib/backends/backend_gtk3.py

+1
Original file line numberDiff line numberDiff line change
@@ -803,6 +803,7 @@ def add_toolitem(self, name, group, position, image_file, description,
803803

804804
if position is None:
805805
position = -1
806+
# TODO implement groups positions
806807
self._toolbar.insert(tbutton, -1)
807808
signal = tbutton.connect('clicked', self._call_tool, name)
808809
tbutton.set_tooltip_text(description)

0 commit comments

Comments
 (0)