don't attempt to use libav ffmpeg shim on ubuntu 12.04

Nathan Goldbaum · Nathan Goldbaum · commit 3bdea02e816e · 2017-03-13T11:49:53.000-05:00
diff --git a/.travis.yml b/.travis.yml
@@ -13,7 +13,6 @@ addons:
     packages:
       - inkscape
       - libav-tools
-      - libavcodec-extra-53
       - gdb
       - mencoder
       - dvipng
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
@@ -400,16 +400,23 @@ def isAvailable(cls):
         if not bin_path:
             return False
         try:
-            p = subprocess.Popen(bin_path,
-                             shell=False,
-                             stdout=subprocess.PIPE,
-                             stderr=subprocess.PIPE,
-                             creationflags=subprocess_creation_flags)
-            p.communicate()
+            p = subprocess.Popen(
+                bin_path,
+                shell=False,
+                stdout=subprocess.PIPE,
+                stderr=subprocess.PIPE,
+                creationflags=subprocess_creation_flags)
+            if not cls._handle_subprocess(p):
+                return False
             return True
         except OSError:
             return False
 
+    @classmethod
+    def _handle_subprocess(cls, process):
+        process.communicate()
+        return True
+
 
 class FileMovieWriter(MovieWriter):
     '''`MovieWriter` for writing to individual files and stitching at the end.
@@ -584,10 +591,18 @@ def output_args(self):
 
         return args + ['-y', self.outfile]
 
+    @classmethod
+    def _handle_subprocess(cls, process):
+        _, err = process.communicate()
+        # Ubuntu 12.04 ships a broken ffmpeg binary which we shouldn't use
+        if 'Libav' in err.decode():
+            return False
+        return True
+
 
 # Combine FFMpeg options with pipe-based writing
 @writers.register('ffmpeg')
-class FFMpegWriter(MovieWriter, FFMpegBase):
+class FFMpegWriter(FFMpegBase, MovieWriter):
     '''Pipe-based ffmpeg writer.
 
     Frames are streamed directly to ffmpeg via a pipe and written in a single
@@ -608,7 +623,7 @@ def _args(self):
 
 # Combine FFMpeg options with temp file-based writing
 @writers.register('ffmpeg_file')
-class FFMpegFileWriter(FileMovieWriter, FFMpegBase):
+class FFMpegFileWriter(FFMpegBase, FileMovieWriter):
     '''File-based ffmpeg writer.
 
     Frames are written to temporary files on disk and then stitched
