Bring existing parameter keyword only deprecations in line with documentation

ksunden · ksunden · commit 3cb60369fff6 · 2023-07-27T13:10:39.000-05:00
diff --git a/ci/mypy-stubtest-allowlist.txt b/ci/mypy-stubtest-allowlist.txt
@@ -54,26 +54,14 @@ matplotlib.cm.register_cmap
 matplotlib.cm.unregister_cmap
 matplotlib.collections.PolyCollection.span_where
 matplotlib.gridspec.GridSpecBase.get_grid_positions
-matplotlib.widgets.Lasso.__init__
-matplotlib.widgets.PolygonSelector.__init__
-matplotlib.widgets.Slider.__init__
-matplotlib.widgets.RangeSlider.__init__
-matplotlib.widgets.TextBox.__init__
-matplotlib.widgets.Cursor.__init__
-matplotlib.widgets.SpanSelector.__init__
-matplotlib.widgets.ToolLineHandles.__init__
-matplotlib.widgets.ToolHandles.__init__
-matplotlib.widgets.LassoSelector.__init__
 matplotlib.widgets.MultiCursor.needclear
 
 # 3.8 deprecations
-matplotlib.axes._base._AxesBase.get_tightbbox
 matplotlib.cbook.get_sample_data
 matplotlib.contour.ContourSet.allkinds
 matplotlib.contour.ContourSet.allsegs
 matplotlib.contour.ContourSet.tcolors
 matplotlib.contour.ContourSet.tlinewidths
-matplotlib.figure.FigureBase.get_tightbbox
 matplotlib.ticker.LogLocator.__init__
 matplotlib.ticker.LogLocator.set_params
 
diff --git a/lib/matplotlib/axes/_base.pyi b/lib/matplotlib/axes/_base.pyi
@@ -367,9 +367,9 @@ class _AxesBase(martist.Artist):
     def get_tightbbox(
         self,
         renderer: RendererBase | None = ...,
+        *,
         call_axes_locator: bool = ...,
         bbox_extra_artists: Sequence[Artist] | None = ...,
-        *,
         for_layout_only: bool = ...
     ) -> Bbox | None: ...
     def twinx(self) -> _AxesBase: ...
diff --git a/lib/matplotlib/figure.pyi b/lib/matplotlib/figure.pyi
@@ -223,6 +223,7 @@ class FigureBase(Artist):
     def get_tightbbox(
         self,
         renderer: RendererBase | None = ...,
+        *,
         bbox_extra_artists: Iterable[Artist] | None = ...,
     ) -> Bbox: ...
 
diff --git a/lib/matplotlib/widgets.pyi b/lib/matplotlib/widgets.pyi
@@ -96,6 +96,7 @@ class Slider(SliderBase):
         label: str,
         valmin: float,
         valmax: float,
+        *,
         valinit: float = ...,
         valfmt: str | None = ...,
         closedmin: bool = ...,
@@ -105,7 +106,6 @@ class Slider(SliderBase):
         dragging: bool = ...,
         valstep: float | ArrayLike | None = ...,
         orientation: Literal["horizontal", "vertical"] = ...,
-        *,
         initcolor: ColorType = ...,
         track_color: ColorType = ...,
         handle_style: dict[str, Any] | None = ...,
@@ -127,6 +127,7 @@ class RangeSlider(SliderBase):
         label: str,
         valmin: float,
         valmax: float,
+        *,
         valinit: tuple[float, float] | None = ...,
         valfmt: str | None = ...,
         closedmin: bool = ...,
@@ -181,6 +182,7 @@ class TextBox(AxesWidget):
         ax: Axes,
         label: str,
         initial: str = ...,
+        *,
         color: ColorType = ...,
         hovercolor: ColorType = ...,
         label_pad: float = ...,
@@ -236,6 +238,7 @@ class Cursor(AxesWidget):
     def __init__(
         self,
         ax: Axes,
+        *,
         horizOn: bool = ...,
         vertOn: bool = ...,
         useblit: bool = ...,
@@ -317,6 +320,7 @@ class SpanSelector(_SelectorWidget):
         ax: Axes,
         onselect: Callable[[float, float], Any],
         direction: Literal["horizontal", "vertical"],
+        *,
         minspan: float = ...,
         useblit: bool = ...,
         props: dict[str, Any] | None = ...,
@@ -348,6 +352,7 @@ class ToolLineHandles:
         ax: Axes,
         positions: ArrayLike,
         direction: Literal["horizontal", "vertical"],
+        *,
         line_props: dict[str, Any] | None = ...,
         useblit: bool = ...,
     ) -> None: ...
@@ -370,6 +375,7 @@ class ToolHandles:
         ax: Axes,
         x: ArrayLike,
         y: ArrayLike,
+        *,
         marker: str = ...,
         marker_props: dict[str, Any] | None = ...,
         useblit: bool = ...,
@@ -436,6 +442,7 @@ class LassoSelector(_SelectorWidget):
         self,
         ax: Axes,
         onselect: Callable[[list[tuple[float, float]]], Any],
+        *,
         useblit: bool = ...,
         props: dict[str, Any] | None = ...,
         button: MouseButton | Collection[MouseButton] | None = ...,
@@ -447,11 +454,11 @@ class PolygonSelector(_SelectorWidget):
         self,
         ax: Axes,
         onselect: Callable[[ArrayLike, ArrayLike], Any],
+        *,
         useblit: bool = ...,
         props: dict[str, Any] | None = ...,
         handle_props: dict[str, Any] | None = ...,
         grab_range: float = ...,
-        *,
         draw_bounding_box: bool = ...,
         box_handle_props: dict[str, Any] | None = ...,
         box_props: dict[str, Any] | None = ...
@@ -473,6 +480,7 @@ class Lasso(AxesWidget):
         ax: Axes,
         xy: tuple[float, float],
         callback: Callable[[list[tuple[float, float]]], Any],
+        *,
         useblit: bool = ...,
     ) -> None: ...
     def onrelease(self, event: Event) -> None: ...
