BUG : fix errors when using fliers

tacaswell · tacaswell · commit 462362f935c1 · 2014-06-28T14:16:07.000-04:00
doplot for horizontal boxes (internal bxp helper function) assumes that
it will be passed an even number of positional arguments which it swaps
pair-wise.  The code to draw the fliers also passes in a format string
which breaks the assumption.

 - re-worked how `bxp` deals with the `sym` input
 - minor pep8
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -39,6 +39,7 @@
 import matplotlib.transforms as mtrans
 from matplotlib.container import BarContainer, ErrorbarContainer, StemContainer
 from matplotlib.axes._base import _AxesBase
+from matplotlib.axes._base import _process_plot_format
 
 iterable = cbook.iterable
 is_string_like = cbook.is_string_like
@@ -3254,21 +3255,23 @@ def bxp(self, bxpstats, positions=None, widths=None, vert=True,
         if whiskerprops is not None:
             final_whiskerprops.update(whiskerprops)
 
+        # set up the default flier properties
+        final_flierprops = dict(linestyle='none', marker='+',
+                    markeredgecolor='b',
+                    markerfacecolor='none')
         # flier (outlier) properties
         if flierprops is not None:
-            sym = flierprops.pop('sym', '')
-
-            if sym == '':
-                final_flierprops = dict(linestyle='none', marker='+',
-                                        markeredgecolor='b',
-                                        markerfacecolor='none')
-            else:
-                final_flierprops = dict(linestyle='none')
+            sym = flierprops.pop('sym', None)
+
+            # watch inverted logic, checks for non-default
+            # value of `sym`
+            if not (sym == '' or (sym is None)):
+                # process the symbol string
+                # discarded linestyle
+                _, marker, color = _process_plot_format(sym)
+                final_flierprops['marker'] = marker
+                final_flierprops['color'] = color
             final_flierprops.update(flierprops)
-        else:
-            sym = ''
-            final_flierprops = dict(linestyle='none', marker='+',
-                                    markeredgecolor='b')
 
         # median line properties
         final_medianprops = dict(linestyle='-', color='red')
@@ -3398,10 +3401,10 @@ def dopatch(xs, ys, **kwargs):
 
             # draw the whiskers
             whiskers.extend(doplot(
-                whisker_x, whiskerlo_y,**final_whiskerprops
+                whisker_x, whiskerlo_y, **final_whiskerprops
             ))
             whiskers.extend(doplot(
-                whisker_x, whiskerhi_y,**final_whiskerprops
+                whisker_x, whiskerhi_y, **final_whiskerprops
             ))
 
             # maybe draw the caps:
@@ -3427,7 +3430,7 @@ def dopatch(xs, ys, **kwargs):
             # maybe draw the fliers
             if showfliers:
                 fliers.extend(doplot(
-                    flier_x, flier_y, sym, **final_flierprops
+                    flier_x, flier_y, **final_flierprops
                 ))
 
         # fix our axes/ticks up a little
