RangeSlider handle set_val bugfix

andrew-fennell · andrew-fennell · commit 4bb927430635 · 2022-03-26T23:00:35.000-05:00
diff --git a/lib/matplotlib/widgets.py b/lib/matplotlib/widgets.py
@@ -813,7 +813,10 @@ def _update_val_from_pos(self, pos):
             val = self._max_in_bounds(pos)
             self.set_max(val)
         if self._active_handle:
-            self._active_handle.set_xdata([val])
+            if self.orientation == "vertical":
+                self._active_handle.set_ydata([val])
+            else:
+                self._active_handle.set_xdata([val])
 
     def _update(self, event):
         """Update the slider position."""
@@ -834,13 +837,21 @@ def _update(self, event):
             event.canvas.release_mouse(self.ax)
             self._active_handle = None
             return
-
-        # determine which handle was grabbed
-        handle = self._handles[
-            np.argmin(
-                np.abs([h.get_xdata()[0] - event.xdata for h in self._handles])
-            )
-        ]
+        
+        if self.orientation == "vertical":
+            # determine which handle was grabbed
+            handle = self._handles[
+                np.argmin(
+                    np.abs([h.get_ydata()[0] - event.ydata for h in self._handles])
+                )
+            ]
+        else:
+            # determine which handle was grabbed
+            handle = self._handles[
+                np.argmin(
+                    np.abs([h.get_xdata()[0] - event.xdata for h in self._handles])
+                )
+            ]
         # these checks ensure smooth behavior if the handles swap which one
         # has a higher value. i.e. if one is dragged over and past the other.
         if handle is not self._active_handle:
@@ -904,14 +915,34 @@ def set_val(self, val):
             xy[2] = .75, val[1]
             xy[3] = .75, val[0]
             xy[4] = .25, val[0]
+
+            hbottom_pos = self._handles[0].get_ydata()
+            htop_pos = self._handles[1].get_ydata()
+            if hbottom_pos != val[0]:
+                hbottom_pos[0] = val[0]
+                self._handles[0].set_ydata(hbottom_pos)
+            if htop_pos != val[1]:
+                htop_pos[0] = val[1]
+                self._handles[1].set_ydata(htop_pos)
         else:
             xy[0] = val[0], .25
             xy[1] = val[0], .75
             xy[2] = val[1], .75
             xy[3] = val[1], .25
             xy[4] = val[0], .25
+
+            hleft_pos = self._handles[0].get_xdata()
+            hright_pos = self._handles[1].get_xdata()
+            if hleft_pos != val[0]:
+                hleft_pos[0] = val[0]
+                self._handles[0].set_xdata(hleft_pos)
+            if hright_pos != val[1]:
+                hright_pos[0] = val[1]
+                self._handles[1].set_xdata(hright_pos)
+
         self.poly.xy = xy
         self.valtext.set_text(self._format(val))
+
         if self.drawon:
             self.ax.figure.canvas.draw_idle()
         self.val = val
