Add a version number in the qlmanage cache key

jkseppan · jkseppan · commit 5869ed000e93 · 2020-08-01T06:07:30.000+03:00
diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
@@ -385,10 +385,12 @@ def impl(args, regex, min_ver=None, ignore_exit_code=False):
                 stdout=subprocess.DEVNULL,
                 stderr=subprocess.DEVNULL
             )
+            # qlmanage has no version number, use the OS version
+            version = subprocess.check_output(["sw_vers", "-productVersion"])
         except (FileNotFoundError, subprocess.CalledProcessError):
             raise ExecutableNotFoundError()
-        return _ExecInfo("qlmanage", "")
-
+        else:
+            return _ExecInfo("qlmanage", version)
     else:
         raise ValueError("Unknown executable: {!r}".format(name))
 
diff --git a/lib/matplotlib/testing/compare.py b/lib/matplotlib/testing/compare.py
@@ -126,7 +126,7 @@ def __init__(self):
         self._proc = None
         self._tmpdir = TemporaryDirectory()
         self._tmppath = Path(self._tmpdir.name)
-        self._version = 'qlmanage'
+        self._version = mpl._get_executable_info("qlmanage").version
 
     def __call__(self, orig, dest):
         try:
