Update set eb_line_style and fix formatting issues

hasanrashid · hasanrashid · commit 596bcded7e0e · 2025-04-13T20:52:44.000Z
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -3453,14 +3453,15 @@ def _errorevery_to_mask(x, errorevery):
         everymask[errorevery] = True
         return everymask
 
-    @_api.make_keyword_only("3.10", "ecolor")
+    @_api.make_keyword_only("3.10", "elinestyle")
     @_preprocess_data(replace_names=["x", "y", "xerr", "yerr"],
                       label_namer="y")
     @_docstring.interpd
     def errorbar(self, x, y, yerr=None, xerr=None,
-                 fmt='', ecolor=None, elinewidth=None, elinestyle=None, capsize=None,
+                 fmt='', ecolor=None, elinewidth=None, capsize=None,
                  barsabove=False, lolims=False, uplims=False,
                  xlolims=False, xuplims=False, errorevery=1, capthick=None,
+                 elinestyle=None,
                  **kwargs):
         """
         Plot y versus x as lines and/or markers with attached errorbars.
@@ -3715,6 +3716,12 @@ def _upcast_err(err):
             if key in kwargs:
                 eb_lines_style[key] = kwargs[key]
 
+        if elinestyle is not None:
+            eb_lines_style['style'] = elinestyle
+            #if xerr is not None and yerr is not None:
+                #barcols[-2].set_linestyle(elinestyle)
+                #barcols[-1].set_linestyle(elinestyle)
+
         # Make the style dict for caps (the "hats").
         eb_cap_style = {**base_style, 'linestyle': 'none'}
         capsize = mpl._val_or_rc(capsize, "errorbar.capsize")
@@ -3824,17 +3831,9 @@ def apply_mask(arrays, mask):
         else:
             for axis in caplines:
                 for l in caplines[axis]:
-                    self.add_line(l)
-
+                    self.add_line(l)                    
         self._request_autoscale_view()
         caplines = caplines['x'] + caplines['y']
-
-        if(elinestyle is not None):
-            if(xerr is not None and yerr is not None): 
-                barcols[-2].set_linestyle(elinestyle)
-                barcols[-1].set_linestyle(elinestyle)
-
-
         errorbar_container = ErrorbarContainer(
             (data_line, tuple(caplines), tuple(barcols)),
             has_xerr=(xerr is not None), has_yerr=(yerr is not None),
diff --git a/lib/matplotlib/axes/_axes.pyi b/lib/matplotlib/axes/_axes.pyi
@@ -315,7 +315,7 @@ class Axes(_AxesBase):
         *,
         ecolor: ColorType | None = ...,
         elinewidth: float | None = ...,
-        elinestyle: str | None=...,
+        elinestyle: LineStyleType | None=...,
         capsize: float | None = ...,
         barsabove: bool = ...,
         lolims: bool | ArrayLike = ...,
diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
@@ -3041,7 +3041,7 @@ def bar_label(
     *,
     fmt: str | Callable[[float], str] = "%g",
     label_type: Literal["center", "edge"] = "edge",
-    padding: float | ArrayLike = 0,
+    padding: float = 0,
     **kwargs,
 ) -> list[Annotation]:
     return gca().bar_label(
@@ -4117,9 +4117,6 @@ def streamplot(
     integration_direction="both",
     broken_streamlines=True,
     *,
-    integration_max_step_scale=1.0,
-    integration_max_error_scale=1.0,
-    num_arrows=1,
     data=None,
 ):
     __ret = gca().streamplot(
@@ -4141,9 +4138,6 @@ def streamplot(
         maxlength=maxlength,
         integration_direction=integration_direction,
         broken_streamlines=broken_streamlines,
-        integration_max_step_scale=integration_max_step_scale,
-        integration_max_error_scale=integration_max_error_scale,
-        num_arrows=num_arrows,
         **({"data": data} if data is not None else {}),
     )
     sci(__ret.lines)
@@ -4291,8 +4285,6 @@ def violinplot(
     | Callable[[GaussianKDE], float]
     | None = None,
     side: Literal["both", "low", "high"] = "both",
-    facecolor: Sequence[ColorType] | ColorType | None = None,
-    linecolor: Sequence[ColorType] | ColorType | None = None,
     *,
     data=None,
 ) -> dict[str, Collection]:
@@ -4309,8 +4301,6 @@ def violinplot(
         points=points,
         bw_method=bw_method,
         side=side,
-        facecolor=facecolor,
-        linecolor=linecolor,
         **({"data": data} if data is not None else {}),
     )
 
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -4527,26 +4527,11 @@ def test_errorbar_linewidth_type(elinewidth):
 
 def test_errorbar_linestyle_type():
     eb = plt.errorbar([1, 2, 3], [1, 2, 3], yerr=[1, 2, 3], elinestyle='-')
-    assert eb[-1][0].get_linestyle(), '-'
-    eb = plt.errorbar([1, 2, 3], [1, 2, 3], yerr=[1, 2, 3], elinestyle='--')
-    assert eb[-1][0].get_linestyle(), '--'
-    eb = plt.errorbar([1, 2, 3], [1, 2, 3], yerr=[1, 2, 3], elinestyle='-.')
-    assert eb[-1][0].get_linestyle(), '-.'
-    eb = plt.errorbar([1, 2, 3], [1, 2, 3], yerr=[1, 2, 3], elinestyle=':')
-    assert eb[-1][0].get_linestyle(), ':'
-
-    eb = plt.errorbar([1, 2, 3], [1, 2, 3], xerr=[1, 2, 3], yerr=[1, 2, 3], elinestyle='-')
-    assert eb[-1][0].get_linestyle(), '-'
-    assert eb[-1][1].get_linestyle(), '-'
-    eb = plt.errorbar([1, 2, 3], [1, 2, 3], xerr=[1, 2, 3], yerr=[1, 2, 3], elinestyle='--')
-    assert eb[-1][0].get_linestyle(), '--'
-    assert eb[-1][1].get_linestyle(), '--'
-    eb = plt.errorbar([1, 2, 3], [1, 2, 3], xerr=[1, 2, 3], yerr=[1, 2, 3], elinestyle='-.')
-    assert eb[-1][0].get_linestyle(), '-.'
-    assert eb[-1][1].get_linestyle(), '-.'
+    assert eb[-1][0].get_linestyle() == '-'
+
     eb = plt.errorbar([1, 2, 3], [1, 2, 3], xerr=[1, 2, 3], yerr=[1, 2, 3], elinestyle=':')
-    assert eb[-1][0].get_linestyle(), ':'
-    assert eb[-1][1].get_linestyle(), ':'
+    assert eb[-1][0].get_linestyle() == ':'
+    assert eb[-1][1].get_linestyle() == ':'
 
 @check_figures_equal()
 def test_errorbar_nan(fig_test, fig_ref):
