FIX: Disable cursorRect updates from within macosx backend

greglucas · greglucas · commit 662642c947f5 · 2022-05-15T07:39:34.000-06:00
We want to keep control of the cursor updates from within MPL, so
don't allow the App to push a new cursor update when the window
gets updated. This would happen when a TextView would get resized
and update the frame.
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -588,6 +588,10 @@ static CGFloat _get_device_scale(CGContextRef cr)
     Window* window = self->window;
     [window setDelegate: view];
     [window makeFirstResponder: view];
+    // Disable cursorRects so that the cursor doesn't get updated by events
+    // in NSApp (like resizing TextViews), we want to handle the cursor
+    // changes from within MPL with set_cursor() ourselves
+    [window disableCursorRects];
     [[window contentView] addSubview: view];
     [view updateDevicePixelRatio: [window backingScaleFactor]];
 
@@ -989,9 +993,6 @@ -(void)save_figure:(id)sender { gil_call_method(toolbar, "save_figure"); }
         [messagebox setFrame: rect];
         // We want to control the vertical position of
         // the rect by the content size to center it vertically
-        // TODO: This seems to disable the cursor updates with newlines that
-        //       are included in the image hover text. It is only when trying
-        //       to set the frame height based on the contentRect's size.
         [messagebox.layoutManager ensureLayoutForTextContainer: messagebox.textContainer];
         NSRect contentRect = [messagebox.layoutManager usedRectForTextContainer: messagebox.textContainer];
         rect.origin.y = 0.5 * (self->height - contentRect.size.height);
