FIX: fix reading from http/https urls via imread

tacaswell · tacaswell · commit 66ff15a26232 · 2020-08-05T15:14:38.000-04:00
closes #18129
diff --git a/lib/matplotlib/image.py b/lib/matplotlib/image.py
@@ -9,6 +9,8 @@
 from numbers import Number
 from pathlib import Path
 import urllib.parse
+import urllib.request
+from io import BytesIO
 
 import numpy as np
 import PIL.PngImagePlugin
@@ -1470,9 +1472,8 @@ def imread(fname, format=None):
     if isinstance(fname, str):
         parsed = urllib.parse.urlparse(fname)
         if len(parsed.scheme) > 1:  # Pillow doesn't handle URLs directly.
-            from urllib import request
             with urllib.request.urlopen(fname) as response:
-                return imread(response, format=ext)
+                return imread(BytesIO(response.read()), format=ext)
     with img_open(fname) as image:
         return (_pil_png_to_float_array(image)
                 if isinstance(image, PIL.PngImagePlugin.PngImageFile) else
diff --git a/lib/matplotlib/tests/test_image.py b/lib/matplotlib/tests/test_image.py
@@ -1118,3 +1118,9 @@ def test_exact_vmin():
 
     # check than the RBGA values are the same
     assert np.all(from_image == direct_computation)
+
+
+@pytest.mark.network
+@pytest.mark.flaky
+def test_https_imread_smoketest():
+    v = mimage.imread('https://matplotlib.org/1.5.0/_static/logo2.png')
