FIX macos: Use the agg buffer_rgba rather than private attribute

greglucas · greglucas · commit 6bf45cdcfdb2 · 2024-10-10T08:42:40.000-06:00
The _renderer attribute has changed with the pybind11 update and
we aren't able to access it as a buffer anymore. We can use the
buffer_rgba method to get the direct memoryview of the buffer
instead.
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -1236,7 +1236,7 @@ -(void)drawRect:(NSRect)rect
     CGContextRef cr = [[NSGraphicsContext currentContext] CGContext];
 
     if (!(renderer = PyObject_CallMethod(canvas, "get_renderer", ""))
-        || !(renderer_buffer = PyObject_GetAttrString(renderer, "_renderer"))) {
+        || !(renderer_buffer = PyObject_CallMethod(renderer, "buffer_rgba", ""))) {
         PyErr_Print();
         goto exit;
     }

Original file line number	Diff line number	Diff line change
`@@ -1236,7 +1236,7 @@ -(void)drawRect:(NSRect)rect`
`1236`	`1236`	`CGContextRef cr = [[NSGraphicsContext currentContext] CGContext];`
`1237`	`1237`
`1238`	`1238`	`if (!(renderer = PyObject_CallMethod(canvas, "get_renderer", ""))`
`1239`		`- \|\| !(renderer_buffer = PyObject_GetAttrString(renderer, "_renderer"))) {`
	`1239`	`+ \|\| !(renderer_buffer = PyObject_CallMethod(renderer, "buffer_rgba", ""))) {`
`1240`	`1240`	`PyErr_Print();`
`1241`	`1241`	`goto exit;`
`1242`	`1242`	`}`