Let sphinx tests print stdout/err.

anntzer · anntzer · commit 7e305d9eeb4f · 2017-10-08T19:54:21.000-07:00
diff --git a/lib/matplotlib/sphinxext/tests/test_tinypages.py b/lib/matplotlib/sphinxext/tests/test_tinypages.py
@@ -3,7 +3,7 @@
 import filecmp
 from os.path import join as pjoin, dirname, isdir
 import shutil
-from subprocess import call, Popen, PIPE
+import subprocess
 import sys
 import tempfile
 
@@ -19,11 +19,10 @@
 def setup_module():
     """Check we have a recent enough version of sphinx installed.
     """
-    ret = call([sys.executable, '-msphinx', '--help'],
-               stdout=PIPE, stderr=PIPE)
+    args = [sys.executable, '-msphinx', '--help']
+    ret = subprocess.call(args)
     if ret != 0:
-        raise RuntimeError(
-            "'{} -msphinx' does not return 0".format(sys.executable))
+        raise RuntimeError("'{}' returned {}".format(' '.join(args), ret))
 
 
 @cbook.deprecated("2.1", alternative="filecmp.cmp")
@@ -45,16 +44,14 @@ def setup_class(cls):
             cls.html_dir = pjoin(cls.page_build, 'html')
             cls.doctree_dir = pjoin(cls.page_build, 'doctrees')
             # Build the pages with warnings turned into errors
-            cmd = [sys.executable, '-msphinx', '-W', '-b', 'html',
-                   '-d', cls.doctree_dir,
-                   TINY_PAGES,
-                   cls.html_dir]
-            proc = Popen(cmd, stdout=PIPE, stderr=PIPE)
-            out, err = proc.communicate()
-            if proc.returncode != 0:
+            args = [sys.executable, '-msphinx', '-W', '-b', 'html',
+                    '-d', cls.doctree_dir,
+                    TINY_PAGES,
+                    cls.html_dir]
+            ret = subprocess.call([args])
+            if ret != 0:
                 raise RuntimeError(
-                    "'{} -msphinx' failed with stdout:\n{}\nstderr:\n{}\n"
-                    .format(sys.executable, out, err))
+                    "'{}' returned {}".format(' '.join(args), ret))
         except Exception as e:
             shutil.rmtree(cls.page_build)
             raise e
