Check if sphinx-build available before executing the test

Kojoley · Kojoley · commit 808d00dced88 · 2016-07-27T22:44:28.000+03:00
diff --git a/lib/matplotlib/sphinxext/tests/test_tinypages.py b/lib/matplotlib/sphinxext/tests/test_tinypages.py
@@ -14,8 +14,8 @@
 TINY_PAGES = pjoin(HERE, 'tinypages')
 
 
-def setup():
-    # Check we have the sphinx-build command
+def check_sphinx_build():
+    """Check we have the sphinx-build command"""
     try:
         ret = call(['sphinx-build', '--help'], stdout=PIPE, stderr=PIPE)
     except OSError:
@@ -33,10 +33,11 @@ def file_same(file1, file2):
 
 
 class TestTinyPages(object):
-    # Test build and output of tinypages project
+    """Test build and output of tinypages project"""
 
     @classmethod
     def setup_class(cls):
+        check_sphinx_build()
         cls.page_build = tempfile.mkdtemp()
         try:
             cls.html_dir = pjoin(cls.page_build, 'html')
@@ -48,14 +49,12 @@ def setup_class(cls):
                    cls.html_dir]
             proc = Popen(cmd, stdout=PIPE, stderr=PIPE)
             out, err = proc.communicate()
+            if proc.returncode != 0:
+                raise RuntimeError('sphinx-build failed with stdout:\n'
+                                   '{0}\nstderr:\n{1}\n'.format(out, err))
         except Exception as e:
             shutil.rmtree(cls.page_build)
             raise e
-        if proc.returncode != 0:
-            shutil.rmtree(cls.page_build)
-            raise RuntimeError('sphinx-build failed with stdout:\n'
-                               '{0}\nstderr:\n{1}\n'.format(
-                                    out, err))
 
     @classmethod
     def teardown_class(cls):
