Fix issue with get_edgecolors and get_facecolors

oscargus · oscargus · commit 859ff087f07b · 2022-08-05T15:49:04.000+02:00
diff --git a/lib/mpl_toolkits/mplot3d/art3d.py b/lib/mpl_toolkits/mplot3d/art3d.py
@@ -867,9 +867,15 @@ def set_alpha(self, alpha):
         self.stale = True
 
     def get_facecolor(self):
+        if not hasattr(self, '_facecolors2d'):
+            self.axes.M = self.axes.get_proj()
+            self.do_3d_projection()
         return self._facecolors2d
 
     def get_edgecolor(self):
+        if not hasattr(self, '_edgecolors2d'):
+            self.axes.M = self.axes.get_proj()
+            self.do_3d_projection()
         return self._edgecolors2d
 
 
diff --git a/lib/mpl_toolkits/tests/test_mplot3d.py b/lib/mpl_toolkits/tests/test_mplot3d.py
@@ -1812,6 +1812,28 @@ def test_scatter_spiral():
     fig.canvas.draw()
 
 
+def test_Poly3DCollection_get_facecolors():
+    # Smoke test to see that get_facecolors doesn't raise
+    # See GH#4067
+    y, x = np.ogrid[1:10:100j, 1:10:100j]
+    z2 = np.cos(x) ** 3 - np.sin(y) ** 2
+    fig = plt.figure()
+    ax = fig.add_subplot(111, projection='3d')
+    r = ax.plot_surface(x, y, z2, cmap='hot')
+    r.get_facecolors()
+
+
+def test_Poly3DCollection_get_edgecolors():
+    # Smoke test to see that get_edgecolors doesn't raise
+    # See GH#4067
+    y, x = np.ogrid[1:10:100j, 1:10:100j]
+    z2 = np.cos(x) ** 3 - np.sin(y) ** 2
+    fig = plt.figure()
+    ax = fig.add_subplot(111, projection='3d')
+    r = ax.plot_surface(x, y, z2, cmap='hot')
+    r.get_edgecolors()
+
+
 @pytest.mark.parametrize(
     "vertical_axis, proj_expected, axis_lines_expected, tickdirs_expected",
     [
