Warn when trying to start a GUI event loop out of the main thread.

anntzer · anntzer · commit 86f6cb39465f · 2019-12-15T14:47:58.000+01:00
diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
@@ -26,6 +26,10 @@
 import re
 import sys
 import time
+try:
+    import threading
+except ImportError:
+    import dummy_threading as threading
 
 from cycler import cycler
 import matplotlib
@@ -177,6 +181,12 @@ def findobj(o=None, match=None, include_self=True):
     return o.findobj(match, include_self=include_self)
 
 
+def _get_required_interactive_framework():
+    global _backend_mod
+    return getattr(
+        _backend_mod.FigureCanvas, "required_interactive_framework", None)
+
+
 def switch_backend(newbackend):
     """
     Close all open figures and set the Matplotlib backend.
@@ -222,8 +232,7 @@ class _backend_mod(matplotlib.backend_bases._Backend):
     _log.debug("Loaded backend %s version %s.",
                newbackend, _backend_mod.backend_version)
 
-    required_framework = getattr(
-        _backend_mod.FigureCanvas, "required_interactive_framework", None)
+    required_framework = _get_required_interactive_framework()
     if required_framework is not None:
         current_framework = cbook._get_running_interactive_framework()
         if (current_framework and required_framework
@@ -244,9 +253,18 @@ class _backend_mod(matplotlib.backend_bases._Backend):
     matplotlib.backends.backend = newbackend
 
 
+def _warn_if_gui_out_of_main_thread():
+    if (_get_required_interactive_framework()
+            and threading.current_thread() is not threading.main_thread()):
+        cbook._warn_external(
+            "Starting a Matplotlib GUI outside of the main thread will likely "
+            "fail.")
+
+
 def new_figure_manager(*args, **kwargs):
     """Create a new figure manager instance."""
     global _backend_mod
+    _warn_if_gui_out_of_main_thread()
     return _backend_mod.new_figure_manager(*args, **kwargs)
 
 
@@ -275,6 +293,7 @@ def show(*args, **kwargs):
         override the blocking behavior described above.
     """
     global _backend_mod
+    _warn_if_gui_out_of_main_thread()
     return _backend_mod.show(*args, **kwargs)
 
 
