DOC: add comment about buffer overrun at DEBUG

jklymak · jklymak · commit 91654d25abd6 · 2018-03-09T09:22:34.000-08:00
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
@@ -669,7 +669,8 @@ def _args(self):
                 '-s', '%dx%d' % self.frame_size, '-pix_fmt', self.frame_format,
                 '-r', str(self.fps)]
         # Logging is quieted because subprocess.PIPE has limited buffer size.
-
+        # If you have a lot of frames in your animation and set logging to
+        # DEBUG, you will have a buffer overrun.  
         if (_log.getEffectiveLevel() > logging.DEBUG):
             args += ['-loglevel', 'quiet']
         args += ['-i', 'pipe:'] + self.output_args
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -554,9 +554,12 @@ def legend(self, *args, **kwargs):
         if len(extra_args):
             raise TypeError('legend only accepts two non-keyword arguments')
         self.legend_ = mlegend.Legend(self, handles, labels, **kwargs)
-        self.legend_._remove_method = lambda h: setattr(self, 'legend_', None)
+        self.legend_._remove_method = self._remove_legend
         return self.legend_
 
+    def _remove_legend(self, legend):
+        self.legend_ = None
+
     def text(self, x, y, s, fontdict=None, withdash=False, **kwargs):
         """
         Add text to the axes.
