Do not rely on outer scope variables in ImageComparisonTest.test.do_test

Kojoley · Kojoley · commit 9b47575a9423 · 2016-07-23T21:00:32.000+03:00
`do_test` function variables are changed by loop where function was creates.
It will work as you expect only if you call yielded function immediately.
diff --git a/lib/matplotlib/testing/decorators.py b/lib/matplotlib/testing/decorators.py
@@ -242,7 +242,7 @@ def test(self):
                 @knownfailureif(
                     will_fail, fail_msg,
                     known_exception_class=ImageComparisonFailure)
-                def do_test():
+                def do_test(fignum, actual_fname, expected_fname):
                     figure = plt.figure(fignum)
 
                     if self._remove_text:
@@ -269,7 +269,7 @@ def do_test():
                                 (self._freetype_version, ft2font.__freetype_version__))
                         raise
 
-                yield (do_test,)
+                yield (do_test, fignum, actual_fname, expected_fname)
 
 def image_comparison(baseline_images=None, extensions=None, tol=0,
                      freetype_version=None, remove_text=False,
