TST and DOC

jklymak · jklymak · commit a2f73b176b02 · 2020-05-06T15:03:16.000-07:00
diff --git a/lib/matplotlib/figure.py b/lib/matplotlib/figure.py
@@ -1264,13 +1264,16 @@ def add_subplot(self, *args, **kwargs):
 
         Parameters
         ----------
-        *args, int or (int, int, int) or `SubplotSpec`, default: (1, 1, 1)
+        *args, int, (int, int, *index*), or `SubplotSpec`, default: (1, 1, 1)
             The position of the subplot described by one of
 
             - Three integers (*nrows*, *ncols*, *index*). The subplot will
               take the *index* position on a grid with *nrows* rows and
               *ncols* columns. *index* starts at 1 in the upper left corner
-              and increases to the right.
+              and increases to the right. *index* can also be  a two-tuple
+              sepcifying the (*start*, *stop*) indices of the subplot.  i.e.
+              ``fig.add_subplot(3, 1, (1, 2))`` makes a subplot that spans the
+              upper 2/3 of the figure.
             - A 3-digit integer. The digits are interpreted as if given
               separately as three single-digit integers, i.e.
               ``fig.add_subplot(235)`` is the same as
@@ -1378,18 +1381,18 @@ def add_subplot(self, *args, **kwargs):
                                 'position specification.')
         elif nargs == 3:
             newarg = [None] * 3
-            message=("Passing non-integers as three-element "
-                    "position specification is deprecated since "
-                    "%(since)s and will be removed %(removal)s.")
+            message = ("Passing non-integers as three-element "
+                       "position specification is deprecated since "
+                       "%(since)s and will be removed %(removal)s.")
             for nn, arg in enumerate(args[:2]):
                 if not isinstance(arg, Integral):
-                    cbook.warn_deprecated("3.3", message)
+                    cbook.warn_deprecated("3.3", message=message)
                 newarg[nn] = int(arg)
             if isinstance(args[2], tuple):
                 # start/stop two-tuple is allowed...
                 for arg in args[2]:
                     if not isinstance(arg, Integral):
-                        cbook.warn_deprecated("3.3", message)
+                        cbook.warn_deprecated("3.3", message=mesage)
                 newarg[nn] = (int(args[0]), int(args[1]))
             else:
                 newarg[nn] = int(arg)
diff --git a/lib/matplotlib/tests/test_figure.py b/lib/matplotlib/tests/test_figure.py
@@ -533,3 +533,11 @@ def test_removed_axis():
     fig, axs = plt.subplots(2, sharex=True)
     axs[0].remove()
     fig.canvas.draw()
+
+
+def test_add_subplot_twotuple():
+    fig = plt.figure()
+    ax = fig.add_subplot(3, 4, 1)
+    ax2 = fig.add_subplot(3, 2, (3, 5))
+    assert ax2.get_subplotspec().rowspan == range(1, 3)
+    assert ax2.get_subplotspec().colspan == range(0, 1)
