FIX: leaking temporary files in animation saving

tacaswell · tacaswell · commit a36771454405 · 2022-04-01T17:50:52.000-04:00
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
@@ -468,15 +468,13 @@ def grab_frame(self, **savefig_kwargs):
     def finish(self):
         # Call run here now that all frame grabbing is done. All temp files
         # are available to be assembled.
-        self._run()
-        super().finish()  # Will call clean-up
-
-    def _cleanup(self):  # Inline to finish() once cleanup() is removed.
-        super()._cleanup()
-        if self._tmpdir:
-            _log.debug('MovieWriter: clearing temporary path=%s', self._tmpdir)
-            self._tmpdir.cleanup()
-
+        try:
+            self._run()
+            super().finish()
+        finally:
+            if self._tmpdir:
+                _log.debug('MovieWriter: clearing temporary path=%s', self._tmpdir)
+                self._tmpdir.cleanup()
 
 @writers.register('pillow')
 class PillowWriter(AbstractMovieWriter):
