Add shadow coloring for legends and associated tests

tuncbkose · Tranquilled · tuncbkose · commit a3bfb0998cab · 2023-02-26T22:36:19.000+02:00
Co-authored-by: Tranquilled &lt;Tranquilled@users.noreply.github.com&gt;
diff --git a/doc/api/next_api_changes/behavior/24666-TBK.rst b/doc/api/next_api_changes/behavior/24666-TBK.rst
@@ -0,0 +1,6 @@
+Colorful legend shadows
+-------------------------
+The *shadow* parameter of legends now accepts dicts in addition to booleans.
+If it is neither, a ValueError is thrown.
+Dictionaries can contain any keywords for `.patches.Patch`.
+Configuration is currently not supported via :rc:`legend.shadow`.
diff --git a/doc/users/next_whats_new/legend_shadow_colors.rst b/doc/users/next_whats_new/legend_shadow_colors.rst
@@ -0,0 +1,5 @@
+Configurable legend shadows
+-------------------------
+The *shadow* parameter of legends now accepts dicts in addition to booleans.
+Dictionaries can contain any keywords for `.patches.Patch`.
+Configuration is currently not supported via :rc:`legend.shadow`.
diff --git a/lib/matplotlib/legend.py b/lib/matplotlib/legend.py
@@ -31,6 +31,7 @@
 from matplotlib import _api, _docstring, colors, offsetbox
 from matplotlib.artist import Artist, allow_rasterization
 from matplotlib.cbook import silent_list
+from matplotlib.colors import is_color_like
 from matplotlib.font_manager import FontProperties
 from matplotlib.lines import Line2D
 from matplotlib.patches import (Patch, Rectangle, Shadow, FancyBboxPatch,
@@ -216,8 +217,10 @@ def _update_bbox_to_anchor(self, loc_in_canvas):
     Whether round edges should be enabled around the `.FancyBboxPatch` which
     makes up the legend's background.
 
-shadow : bool, default: :rc:`legend.shadow`
+shadow : None, bool or dict, default: :rc:`legend.shadow`
     Whether to draw a shadow behind the legend.
+    The shadow can be configured using `.Patch` keywords.
+    Currently customization in :rc:`legend.shadow` not supported.
 
 framealpha : float, default: :rc:`legend.framealpha`
     The alpha transparency of the legend's background.
@@ -480,6 +483,22 @@ def val_or_rc(val, rc_name):
         self._mode = mode
         self.set_bbox_to_anchor(bbox_to_anchor, bbox_transform)
 
+        # Figure out if self.shadow is valid
+        # If shadow was None, rcParams loads False
+        # So it shouldn't be None here
+
+        if isinstance(self.shadow, dict):
+            self._shadow_props = self.shadow
+            self.shadow = True
+        elif self.shadow in (0, 1, True, False):
+            self._shadow_props = {}
+            self.shadow = bool(self.shadow)
+        else:
+            raise ValueError(
+                'Legend shadow must be a dict or bool, not '
+                f'{self.shadow!r} of type {type(self.shadow)}.'
+            )
+
         # We use FancyBboxPatch to draw a legend frame. The location
         # and size of the box will be updated during the drawing time.
 
@@ -662,8 +681,11 @@ def draw(self, renderer):
         self.legendPatch.set_bounds(bbox.bounds)
         self.legendPatch.set_mutation_scale(fontsize)
 
+        # self.shadow is validated in __init__
+        # So by here it is a bool and self._shadow_props contains any configs
+
         if self.shadow:
-            Shadow(self.legendPatch, 2, -2).draw(renderer)
+            Shadow(self.legendPatch, 2, -2, **self._shadow_props).draw(renderer)
 
         self.legendPatch.draw(renderer)
         self._legend_box.draw(renderer)
diff --git a/lib/matplotlib/rcsetup.py b/lib/matplotlib/rcsetup.py
@@ -1059,7 +1059,7 @@ def _convert_validator_spec(key, conv):
     "legend.labelcolor":     _validate_color_or_linecolor,
     # the relative size of legend markers vs. original
     "legend.markerscale":    validate_float,
-    "legend.shadow":         validate_bool,
+    "legend.shadow":         validate_bool,  # using dict in rcParams not yet implemented
     # whether or not to draw a frame around legend
     "legend.frameon":        validate_bool,
     # alpha value of the legend frame
diff --git a/lib/matplotlib/tests/baseline_images/test_legend/shadow_argument_types.png b/lib/matplotlib/tests/baseline_images/test_legend/shadow_argument_types.png
diff --git a/lib/matplotlib/tests/test_legend.py b/lib/matplotlib/tests/test_legend.py
@@ -532,6 +532,32 @@ def test_empty_bar_chart_with_legend():
     plt.legend()
 
 
+@image_comparison(['shadow_argument_types.png'])
+def test_shadow_argument_types():
+    # Test that different arguments for shadow work as expected
+    fig, ax = plt.subplots()
+    ax.plot([1, 2, 3], label='test')
+
+    legs = (ax.legend(loc='upper left', shadow=True),                          # True
+            ax.legend(loc='upper right', shadow=False),                        # False
+            ax.legend(loc='center left', shadow={'color': 'red'}),             # string
+            ax.legend(loc='center right', shadow={'color': (0.1, 0.2, 0.5)}),  # tuple
+            ax.legend(loc='lower left', shadow={'color': 'tab:cyan'})          # tab
+            )
+    for l in legs:
+        ax.add_artist(l)
+    ax.legend(loc='lower right')  # default
+
+
+def test_shadow_invalid_argument():
+    # Test if invalid argument to legend shadow
+    # (i.e. not [color|bool]) raises ValueError
+    fig, ax = plt.subplots()
+    ax.plot([1, 2, 3], label='test')
+    with pytest.raises(ValueError, match="dict or bool"):
+        ax.legend(loc="upper left", shadow="aardvark")  # Bad argument
+
+
 def test_shadow_framealpha():
     # Test if framealpha is activated when shadow is True
     # and framealpha is not explicitly passed'''
