ENH : add stale flag to all set_* methods in Artist

tacaswell · tacaswell · commit a8865f863f72 · 2015-05-25T00:50:35.000-04:00
diff --git a/lib/matplotlib/artist.py b/lib/matplotlib/artist.py
@@ -316,6 +316,7 @@ def set_transform(self, t):
         self._transform = t
         self._transformSet = True
         self.pchanged()
+        self.stale = True
 
     def get_transform(self):
         """
@@ -532,6 +533,7 @@ def set_snap(self, snap):
         Only supported by the Agg and MacOSX backends.
         """
         self._snap = snap
+        self.stale = True
 
     def get_sketch_params(self):
         """
@@ -579,13 +581,15 @@ def set_sketch_params(self, scale=None, length=None, randomness=None):
             self._sketch = None
         else:
             self._sketch = (scale, length or 128.0, randomness or 16.0)
+        self.stale = True
 
     def set_path_effects(self, path_effects):
         """
         set path_effects, which should be a list of instances of
         matplotlib.patheffect._Base class or its derivatives.
         """
         self._path_effects = path_effects
+        self.stale = True
 
     def get_path_effects(self):
         return self._path_effects
@@ -608,6 +612,7 @@ def set_figure(self, fig):
         if self.figure and self.figure is not self:
             self.add_callback(_stale_figure_callback)
             self.pchanged()
+        self.stale = True
 
     def set_clip_box(self, clipbox):
         """
@@ -617,6 +622,7 @@ def set_clip_box(self, clipbox):
         """
         self.clipbox = clipbox
         self.pchanged()
+        self.stale = True
 
     def set_clip_path(self, path, transform=None):
         """
@@ -669,8 +675,10 @@ def set_clip_path(self, path, transform=None):
         if not success:
             print(type(path), type(transform))
             raise TypeError("Invalid arguments to set_clip_path")
-
+        # this may result in the callbacks being hit twice, but grantees they
+        # will be hit at least once
         self.pchanged()
+        self.stale = True
 
     def get_alpha(self):
         """
@@ -719,7 +727,10 @@ def set_clip_on(self, b):
         ACCEPTS: [True | False]
         """
         self._clipon = b
+        # This may result in the callbacks being hit twice, but ensures they
+        # are hit at least once
         self.pchanged()
+        self.stale = True
 
     def _set_gc_clip(self, gc):
         'Set the clip properly for the gc'
@@ -758,12 +769,13 @@ def set_agg_filter(self, filter_func):
 
         """
         self._agg_filter = filter_func
+        self.stale = True
 
     def draw(self, renderer, *args, **kwargs):
         'Derived classes drawing method'
         if not self.get_visible():
             return
-        self._stale = False
+        self.stale = False
 
     def set_alpha(self, alpha):
         """
@@ -774,6 +786,7 @@ def set_alpha(self, alpha):
         """
         self._alpha = alpha
         self.pchanged()
+        self.stale = True
 
     def set_visible(self, b):
         """
@@ -783,6 +796,7 @@ def set_visible(self, b):
         """
         self._visible = b
         self.pchanged()
+        self.stale = True
 
     def set_animated(self, b):
         """
@@ -792,6 +806,7 @@ def set_animated(self, b):
         """
         self._animated = b
         self.pchanged()
+        self.stale = True
 
     def update(self, props):
         """
@@ -814,6 +829,7 @@ def update(self, props):
         self.eventson = store
         if changed:
             self.pchanged()
+            self.stale = True
 
     def get_label(self):
         """
@@ -832,6 +848,7 @@ def set_label(self, s):
         else:
             self._label = None
         self.pchanged()
+        self.stale = True
 
     def get_zorder(self):
         """
@@ -848,6 +865,7 @@ def set_zorder(self, level):
         """
         self.zorder = level
         self.pchanged()
+        self.stale = True
 
     def update_from(self, other):
         'Copy properties from *other* to *self*.'
@@ -862,6 +880,7 @@ def update_from(self, other):
         self._sketch = other._sketch
         self._path_effects = other._path_effects
         self.pchanged()
+        self.stale = True
 
     def properties(self):
         """
