Skip to content

Commit ad3787c

Browse files
committed
List all the places to update when adding a dependency.
There starts to be so many places to update that it's easy to forget one. At least from my PoV, setup.py is the canonical place; let's not add this list of files next to each copy of the list...
1 parent 9b4985e commit ad3787c

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

setup.py

+7
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,13 @@ def make_release_tree(self, base_dir, files):
310310
package_data=package_data,
311311

312312
python_requires='>={}'.format('.'.join(str(n) for n in py_min_version)),
313+
# When updating the list of dependencies, add an api_changes/development
314+
# entry and also update the following places:
315+
# - lib/matplotlib/__init__.py (matplotlib._check_versions())
316+
# - requirements/testing/minver.txt
317+
# - doc/devel/dependencies.rst
318+
# - .github/workflows/tests.yml
319+
# - environment.yml
313320
install_requires=[
314321
"contourpy>=1.0.1",
315322
"cycler>=0.10",

0 commit comments

Comments
 (0)