Skip to content

Commit b7dadad

Browse files
authored
Merge pull request #8502 from anntzer/update-pr-template
Update PR template to encourage PRs off not master.
2 parents d930503 + 1e52c22 commit b7dadad

File tree

1 file changed

+22
-6
lines changed

1 file changed

+22
-6
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,34 @@
1-
<!--Thank you so much for your PR! To help us review, fill out the form to the best of your ability. Please make use of the development guide at http://matplotlib.org/devdocs/devel/index.html-->
1+
<!--Thank you so much for your PR! To help us review, fill out the form
2+
to the best of your ability. Please make use of the development guide at
3+
https://matplotlib.org/devdocs/devel/index.html-->
24

3-
<!--- Provide a general summary of your changes in the title above, for example "Raises ValueError on Non-Numeric Input to set_xlim". Please avoid non-descriptive titles such as "Addresses issue #8576"-->
5+
<!--Provide a general summary of your changes in the title above, for
6+
example "Raises ValueError on Non-Numeric Input to set_xlim". Please avoid
7+
non-descriptive titles such as "Addresses issue #8576".-->
8+
9+
<!--If you are able to do so, please do not create the
10+
PR out of master, but out of a separate branch. See
11+
https://matplotlib.org/devel/gitwash/development_workflow.html for
12+
instructions.-->
413

514
## PR Summary
6-
<!--- Please provide at least 1-2 sentences describing the pull request in detail. Why is this change required? What problem does it solve? -->
7-
<!--- If it fixes an open issue, please link to the issue here. -->
15+
16+
<!--Please provide at least 1-2 sentences describing the pull request in
17+
detail. Why is this change required? What problem does it solve?-->
18+
19+
<!--If it fixes an open issue, please link to the issue here.-->
820

921
## PR Checklist
22+
1023
- [ ] Has Pytest style unit tests
1124
- [ ] Code is PEP 8 compliant
1225
- [ ] New features are documented, with examples if plot related
1326
- [ ] Documentation is sphinx and numpydoc compliant
1427
- [ ] Added an entry to doc/users/whats_new.rst if major new feature
1528
- [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
1629

17-
<!--We understand that PRs can sometimes be overwhelming, especially as the reviews start coming in. Please let us know
18-
if the reviews are unclear or the recommended next step seems overly demanding , or if you would like help in addressing a reviewer's comments. And please ping us if you've been waiting too long to hear back on your PR-->
30+
<!--We understand that PRs can sometimes be overwhelming, especially as the
31+
reviews start coming in. Please let us know if the reviews are unclear or the
32+
recommended next step seems overly demanding , or if you would like help in
33+
addressing a reviewer's comments. And please ping us if you've been waiting
34+
too long to hear back on your PR.-->

0 commit comments

Comments
 (0)