ENH : first pass at making Line2D objects dirty-aware

tacaswell · tacaswell · commit b8bd396c3ad3 · 2015-05-25T00:50:34.000-04:00
All set_* commands now set dirty to be True if the value
is changed.

This required pre-defining all of the Line2D private attributes in the
`__init__` method so that all of the `set_*` methods work the first
time through.
diff --git a/lib/matplotlib/lines.py b/lib/matplotlib/lines.py
@@ -314,26 +314,47 @@ def __init__(self, xdata, ydata,
         if drawstyle is None:
             drawstyle = 'default'
 
+        self._dashcapstyle = None
+        self._dashjoinstyle = None
+        self._solidjoinstyle = None
+        self._solidcapstyle = None
         self.set_dash_capstyle(dash_capstyle)
         self.set_dash_joinstyle(dash_joinstyle)
         self.set_solid_capstyle(solid_capstyle)
         self.set_solid_joinstyle(solid_joinstyle)
 
+        self._linestyles = None
+        self._drawstyle = None
+        self._linewidth = None
         self.set_linestyle(linestyle)
         self.set_drawstyle(drawstyle)
         self.set_linewidth(linewidth)
+
+        self._color = None
         self.set_color(color)
         self._marker = MarkerStyle()
         self.set_marker(marker)
+
+        self._markevery = None
+        self._markersize = None
+        self._antialiased = None
+
         self.set_markevery(markevery)
         self.set_antialiased(antialiased)
         self.set_markersize(markersize)
+
         self._dashSeq = None
 
+        self._markeredgecolor = None
+        self._markeredgewidth = None
+        self._markerfacecolor = None
+        self._markerfacecoloralt = None
+
         self.set_markerfacecolor(markerfacecolor)
         self.set_markerfacecoloralt(markerfacecoloralt)
         self.set_markeredgecolor(markeredgecolor)
         self.set_markeredgewidth(markeredgewidth)
+
         self.set_fillstyle(fillstyle)
 
         self.verticalOffset = None
@@ -457,6 +478,7 @@ def set_fillstyle(self, fs):
         ACCEPTS: ['full' | 'left' | 'right' | 'bottom' | 'top' | 'none']
         """
         self._marker.set_fillstyle(fs)
+        self.dirty = True
 
     def set_markevery(self, every):
         """Set the markevery property to subsample the plot when using markers.
@@ -509,7 +531,8 @@ def set_markevery(self, every):
         axes-bounding-box-diagonal regardless of the actual axes data limits.
 
         """
-
+        if self._markevery != every:
+            self.dirty = True
         self._markevery = every
 
     def get_markevery(self):
@@ -890,6 +913,8 @@ def set_antialiased(self, b):
 
         ACCEPTS: [True | False]
         """
+        if self._antialiased != b:
+            self.dirty = True
         self._antialiased = b
 
     def set_color(self, color):
@@ -898,6 +923,8 @@ def set_color(self, color):
 
         ACCEPTS: any matplotlib color
         """
+        if color != self._color:
+            self.dirty = True
         self._color = color
 
     def set_drawstyle(self, drawstyle):
@@ -911,6 +938,8 @@ def set_drawstyle(self, drawstyle):
         ACCEPTS: ['default' | 'steps' | 'steps-pre' | 'steps-mid' |
                   'steps-post']
         """
+        if self._drawstyle != drawstyle:
+            self.dirty = True
         self._drawstyle = drawstyle
 
     def set_linewidth(self, w):
@@ -919,7 +948,10 @@ def set_linewidth(self, w):
 
         ACCEPTS: float value in points
         """
-        self._linewidth = float(w)
+        w = float(w)
+        if self._linewidth != w:
+            self.dirty = True
+        self._linewidth = w
 
     def set_linestyle(self, ls):
         """
@@ -1021,6 +1053,8 @@ def set_markeredgecolor(self, ec):
         """
         if ec is None:
             ec = 'auto'
+        if self._markeredgecolor != ec:
+            self.dirty = True
         self._markeredgecolor = ec
 
     def set_markeredgewidth(self, ew):
@@ -1031,6 +1065,8 @@ def set_markeredgewidth(self, ew):
         """
         if ew is None:
             ew = rcParams['lines.markeredgewidth']
+        if self._markeredgewidth != ew:
+            self.dirty = True
         self._markeredgewidth = ew
 
     def set_markerfacecolor(self, fc):
@@ -1041,7 +1077,8 @@ def set_markerfacecolor(self, fc):
         """
         if fc is None:
             fc = 'auto'
-
+        if self._markerfacecolor != fc:
+            self.dirty = True
         self._markerfacecolor = fc
 
     def set_markerfacecoloralt(self, fc):
@@ -1052,7 +1089,8 @@ def set_markerfacecoloralt(self, fc):
         """
         if fc is None:
             fc = 'auto'
-
+        if self._markerfacecoloralt != fc:
+            self.dirty = True
         self._markerfacecoloralt = fc
 
     def set_markersize(self, sz):
@@ -1061,7 +1099,10 @@ def set_markersize(self, sz):
 
         ACCEPTS: float
         """
-        self._markersize = float(sz)
+        sz = float(sz)
+        if self._markersize != sz:
+            self.dirty = True
+        self._markersize = sz
 
     def set_xdata(self, x):
         """
@@ -1071,6 +1112,7 @@ def set_xdata(self, x):
         """
         self._xorig = x
         self._invalidx = True
+        self.dirty = True
 
     def set_ydata(self, y):
         """
@@ -1080,6 +1122,7 @@ def set_ydata(self, y):
         """
         self._yorig = y
         self._invalidy = True
+        self.dirty = True
 
     def set_dashes(self, seq):
         """
@@ -1093,6 +1136,8 @@ def set_dashes(self, seq):
             self.set_linestyle('-')
         else:
             self.set_linestyle('--')
+        if self._dashSeq != seq:
+            self.dirty = True
         self._dashSeq = seq  # TODO: offset ignored for now
 
     def _draw_lines(self, renderer, gc, path, trans):
@@ -1276,6 +1321,8 @@ def set_dash_joinstyle(self, s):
         if s not in self.validJoin:
             raise ValueError('set_dash_joinstyle passed "%s";\n' % (s,)
                              + 'valid joinstyles are %s' % (self.validJoin,))
+        if self._dashjoinstyle != s:
+            self.dirty = True
         self._dashjoinstyle = s
 
     def set_solid_joinstyle(self, s):
@@ -1287,6 +1334,9 @@ def set_solid_joinstyle(self, s):
         if s not in self.validJoin:
             raise ValueError('set_solid_joinstyle passed "%s";\n' % (s,)
                              + 'valid joinstyles are %s' % (self.validJoin,))
+
+        if self._solidjoinstyle != s:
+            self.dirty = True
         self._solidjoinstyle = s
 
     def get_dash_joinstyle(self):
@@ -1311,7 +1361,8 @@ def set_dash_capstyle(self, s):
         if s not in self.validCap:
             raise ValueError('set_dash_capstyle passed "%s";\n' % (s,)
                              + 'valid capstyles are %s' % (self.validCap,))
-
+        if self._dashcapstyle != s:
+            self.dirty = True
         self._dashcapstyle = s
 
     def set_solid_capstyle(self, s):
@@ -1324,7 +1375,8 @@ def set_solid_capstyle(self, s):
         if s not in self.validCap:
             raise ValueError('set_solid_capstyle passed "%s";\n' % (s,)
                              + 'valid capstyles are %s' % (self.validCap,))
-
+        if self._solidcapstyle != s:
+            self.dirty = True
         self._solidcapstyle = s
 
     def get_dash_capstyle(self):
