Merge pull request #23569 from kianelbo/cb-xlabel

QuLogic · web-flow · commit bdf83bb2ff30 · 2022-08-26T22:31:56.000-04:00
Fix hidden xlabel bug in colorbar
diff --git a/lib/matplotlib/colorbar.py b/lib/matplotlib/colorbar.py
@@ -353,7 +353,6 @@ def __init__(self, ax, mappable=None, *, cmap=None,
         for spine in self.ax.spines.values():
             spine.set_visible(False)
         self.outline = self.ax.spines['outline'] = _ColorbarSpine(self.ax)
-        self._short_axis().set_visible(False)
         # Only kept for backcompat; remove after deprecation of .patch elapses.
         self._patch = mpatches.Polygon(
             np.empty((0, 2)),
diff --git a/lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_keeping_xlabel.png b/lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_keeping_xlabel.png
diff --git a/lib/matplotlib/tests/test_colorbar.py b/lib/matplotlib/tests/test_colorbar.py
@@ -721,6 +721,17 @@ def test_colorbar_label():
     assert cbar3.ax.get_xlabel() == 'horizontal cbar'
 
 
+@image_comparison(['colorbar_keeping_xlabel.png'], style='mpl20')
+def test_keeping_xlabel():
+    # github issue #23398 - xlabels being ignored in colorbar axis
+    arr = np.arange(25).reshape((5, 5))
+    fig, ax = plt.subplots()
+    im = ax.imshow(arr)
+    cbar = plt.colorbar(im)
+    cbar.ax.set_xlabel('Visible Xlabel')
+    cbar.set_label('YLabel')
+
+
 @pytest.mark.parametrize("clim", [(-20000, 20000), (-32768, 0)])
 def test_colorbar_int(clim):
     # Check that we cast to float early enough to not
