Update rcdefaults to use style.core.use()

chahak13 · chahak13 · commit c23cb2914beb · 2023-10-23T21:29:49.000-04:00
diff --git a/lib/matplotlib/__init__.py b/lib/matplotlib/__init__.py
@@ -1254,13 +1254,10 @@ def rcdefaults():
         Use a specific style file.  Call ``style.use('default')`` to restore
         the default style.
     """
-    # Deprecation warnings were already handled when creating rcParamsDefault,
-    # no need to reemit them here.
-    with _api.suppress_matplotlib_deprecation_warning():
-        from .style.core import STYLE_BLACKLIST
-        rcParams.clear()
-        # rcParams.update({k: v for k, v in rcParams.items()
-        #                  if k not in STYLE_BLACKLIST})
+    # # Deprecation warnings were already handled when creating rcParamsDefault,
+    # # no need to reemit them here.
+    from .style import core
+    core.use('default')
 
 
 def rc_file_defaults():
diff --git a/lib/matplotlib/style/core.py b/lib/matplotlib/style/core.py
@@ -149,6 +149,7 @@ def use(style):
             else:
                 filtered[k] = style[k]
         mpl.rcParams.update(filtered)
+    mpl.rcParams._new_child()
 
 
 @contextlib.contextmanager
diff --git a/lib/matplotlib/tests/test_rcparams.py b/lib/matplotlib/tests/test_rcparams.py
@@ -664,3 +664,17 @@ def test_rcparams_getdefaults():
     defaults = mpl.rcParams.getdefaults()
     mpl.rcParams.clear()
     assert defaults == mpl.rcParams
+
+
+def test_rcdefaults():
+    # webagg.port is a style blacklisted key that shouldn't be
+    # updated when resetting rcParams to default values.
+    mpl.rcParams["webagg.port"] = 9000
+    # lines.linewidth is not a style blacklisted key and should be
+    # reset to the default value.
+    # breakpoint()
+    lw = mpl.rcParams.getdefault("lines.linewidth")
+    mpl.rcParams["lines.linewidth"] = lw + 1
+    mpl.rcdefaults()
+    assert mpl.rcParams["webagg.port"] == 9000
+    assert mpl.rcParams["lines.linewidth"] == lw
