wireframe3d raise when both cstride and rstride are 0

jenshnielsen · jenshnielsen · commit c93223da2dee · 2015-08-02T18:02:17.000+01:00
diff --git a/lib/mpl_toolkits/mplot3d/axes3d.py b/lib/mpl_toolkits/mplot3d/axes3d.py
@@ -1765,6 +1765,9 @@ def plot_wireframe(self, X, Y, Z, *args, **kwargs):
         else:
             cii = []
 
+        if rstride == 0 and cstride == 0:
+            raise ValueError("Either rstride or cstride must be non zero")
+
         # If the inputs were empty, then just
         # reset everything.
         if Z.size == 0 :
diff --git a/lib/mpl_toolkits/tests/test_mplot3d.py b/lib/mpl_toolkits/tests/test_mplot3d.py
@@ -1,6 +1,9 @@
+import sys
+import nose
+from nose.tools import assert_raises
 from mpl_toolkits.mplot3d import Axes3D, axes3d
 from matplotlib import cm
-from matplotlib.testing.decorators import image_comparison
+from matplotlib.testing.decorators import image_comparison, cleanup
 import matplotlib.pyplot as plt
 import numpy as np
 
@@ -189,6 +192,17 @@ def test_wireframe3dzerorstride():
     X, Y, Z = axes3d.get_test_data(0.05)
     ax.plot_wireframe(X, Y, Z, rstride=0, cstride=10)
 
+@cleanup
+def test_wireframe3dzerostrideraises():
+    if sys.version_info[:2] < (2, 7):
+        raise nose.SkipTest("assert_raises as context manager "
+                            "not supported with Python < 2.7")
+    fig = plt.figure()
+    ax = fig.add_subplot(111, projection='3d')
+    X, Y, Z = axes3d.get_test_data(0.05)
+    with assert_raises(ValueError):
+        ax.plot_wireframe(X, Y, Z, rstride=0, cstride=0)
+
 @image_comparison(baseline_images=['quiver3d'], remove_text=True)
 def test_quiver3d():
     fig = plt.figure()
