fix(comment): #28701 make FillBetweenPolyCollection._update_axes_datalim @timhoffm #28702 (comment)

cmp0xff · cmp0xff · commit cf44eb7ddc3e · 2024-09-06T19:50:36.000+02:00
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -5599,14 +5599,7 @@ def _fill_between_x_or_y(
         """
         collection = mcoll.FillBetweenPolyCollection(
             ind_dir, ind, dep1, dep2,
-            where=where, interpolate=interpolate, step=step, _axes=self, **kwargs)
-
-        # now update the datalim and autoscale
-        up_x = up_y = True
-        if up_xy := getattr(collection, "_up_xy", None):
-            up_x, up_y = up_xy(self.transData)
-
-        self.update_datalim(collection._pts, updatex=up_x, updatey=up_y)
+            where=where, interpolate=interpolate, step=step, axes=self, **kwargs)
 
         self.add_collection(collection, autolim=False)
         self._request_autoscale_view()
diff --git a/lib/matplotlib/collections.py b/lib/matplotlib/collections.py
@@ -1258,12 +1258,14 @@ def set_verts_and_codes(self, verts, codes):
 class FillBetweenPolyCollection(PolyCollection):
     def __init__(
             self, t_direction, t, f1, f2, *,
-            where=None, interpolate=False, step=None, _axes=None, **kwargs):
+            where=None, interpolate=False, step=None, axes=None, **kwargs):
         self.t_direction = t_direction
-        kwargs = self._normalise_kwargs(_axes, **kwargs)
+        kwargs = self._normalise_kwargs(axes, **kwargs)
         polys = self._make_verts(
-            t, f1, f2, where, interpolate, step, _axes, **kwargs)
+            t, f1, f2, where, interpolate, step, axes, **kwargs)
         super().__init__(polys, **kwargs)
+        if axes is not None:
+            self._update_axes_datalim(axes, kwargs.get("transform"))
 
     @property
     def _f_direction(self):
@@ -1317,9 +1319,6 @@ def _make_verts(self, t, f1, f2, where, interpolate, step, axes, **kwargs):
         self._pts = self._normalise_pts(np.vstack([
             np.hstack([t[where, None], dep[where, None]]) for dep in (f1, f2)]))
 
-        if "transform" in kwargs:
-            self._up_xy = kwargs["transform"].contains_branch_seperately
-
         return polys
 
     def _normalise_kwargs(self, axes, **kwargs):
@@ -1385,6 +1384,13 @@ def _get_interp_point(self, t, f1, f2, idx):
     def _normalise_pts(self, pts):
         return pts[:, ::-1] if self.t_direction == "y" else pts
 
+    def _update_axes_datalim(self, axes, transform):
+        """Update the datalim and autoscale."""
+        if transform is not None:
+            up_x, up_y = transform.contains_branch_seperately(axes.transData)
+        else:
+            up_x = up_y = True
+        axes.update_datalim(self._pts, updatex=up_x, updatey=up_y)
 
 class RegularPolyCollection(_CollectionWithSizes):
     """A collection of n-sided regular polygons."""
diff --git a/lib/matplotlib/collections.pyi b/lib/matplotlib/collections.pyi
@@ -120,7 +120,7 @@ class FillBetweenPolyCollection(PolyCollection):
         where: Sequence[bool] | None = ...,
         interpolate: bool = ...,
         step: Literal["pre", "post", "mid"] | None = ...,
-        _axes: "Axes | None" = ...,
+        axes: "Axes | None" = ...,
         **kwargs,
     ) -> None: ...
     @property
