Skip to content

Commit dc55f80

Browse files
committed
Bounds check returns value.
1 parent ea899aa commit dc55f80

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

lib/matplotlib/widgets.py

+9-10
Original file line numberDiff line numberDiff line change
@@ -330,13 +330,17 @@ def __init__(self, ax, label, valmin, valmax, valinit=0.5, valfmt='%1.2f',
330330
if slidermax is not None and not hasattr(slidermax, 'val'):
331331
raise ValueError("Argument slidermax ({}) has no 'val'"
332332
.format(type(slidermax)))
333-
333+
self.closedmin = closedmin
334+
self.closedmax = closedmax
335+
self.slidermin = slidermin
336+
self.slidermax = slidermax
337+
self.drag_active = False
334338
self.valmin = valmin
335339
self.valmax = valmax
340+
valinit = self._value_in_bounds(valinit)
336341
self.val = valinit
337342
self.valinit = valinit
338343
self.poly = ax.axvspan(valmin, valinit, 0, 1, **kwargs)
339-
340344
self.vline = ax.axvline(valinit, 0, 1, color='r', lw=1)
341345

342346
self.valfmt = valfmt
@@ -361,12 +365,7 @@ def __init__(self, ax, label, valmin, valmax, valinit=0.5, valfmt='%1.2f',
361365
self.cnt = 0
362366
self.observers = {}
363367

364-
self.closedmin = closedmin
365-
self.closedmax = closedmax
366-
self.slidermin = slidermin
367-
self.slidermax = slidermax
368-
self.drag_active = False
369-
self._value_in_bounds(valinit)
368+
self.set_val(valinit)
370369

371370
def _value_in_bounds(self, val):
372371
""" Makes sure self.val is with given bounds."""
@@ -388,7 +387,7 @@ def _value_in_bounds(self, val):
388387
if not self.closedmax:
389388
return
390389
val = self.slidermax.val
391-
return val
390+
return val
392391

393392
def _update(self, event):
394393
"""update the slider position"""
@@ -412,7 +411,7 @@ def _update(self, event):
412411
event.canvas.release_mouse(self.ax)
413412
return
414413
val = event.xdata
415-
self._value_in_bounds(val)
414+
self.set_val(self._value_in_bounds(val))
416415

417416
def set_val(self, val):
418417
xy = self.poly.xy

0 commit comments

Comments
 (0)