Skip to content

Commit e57b235

Browse files
committed
Deprecate FigureCanvasQT.keyAutoRepeat.
No other backend allows ignoring autorepeated keypresses. Moreover, such keypresses can easily be ignored in the key press handler by directly checking on `event.isAutoRepeat()`.
1 parent 5a8f4ea commit e57b235

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Deprecations
2+
````````````
3+
The `~.FigureCanvasQT.keyAutoRepeat` property is deprecated. Directly check
4+
``event.guiEvent.isAutoRepeat()`` in the event handler to decide whether to
5+
handle autorepeated key presses.

lib/matplotlib/backends/backend_qt5.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from __future__ import (absolute_import, division, print_function,
2-
unicode_literals)
31
import six
42

53
import functools
@@ -378,13 +376,17 @@ def keyReleaseEvent(self, event):
378376
FigureCanvasBase.key_release_event(self, key, guiEvent=event)
379377

380378
@property
379+
@cbook.deprecated("3.0", "Manually check `event.guiEvent.isAutoRepeat()` "
380+
"in the event handler.")
381381
def keyAutoRepeat(self):
382382
"""
383383
If True, enable auto-repeat for key events.
384384
"""
385385
return self._keyautorepeat
386386

387387
@keyAutoRepeat.setter
388+
@cbook.deprecated("3.0", "Manually check `event.guiEvent.isAutoRepeat()` "
389+
"in the event handler.")
388390
def keyAutoRepeat(self, val):
389391
self._keyautorepeat = bool(val)
390392

0 commit comments

Comments
 (0)