Raise TypeError on unsupported kwargs of spy()

timhoffm · timhoffm · commit e6e8fae0c803 · 2018-06-02T12:03:30.000+02:00
diff --git a/doc/api/next_api_changes/2018-06-02-TH.rst b/doc/api/next_api_changes/2018-06-02-TH.rst
@@ -0,0 +1,6 @@
+ `matplotlib.axes.Axes.spy` raises `TypeError` for unsupported kwargs
+---------------------------------------------------------------------
+
+The method `matplotlib.axes.Axes.spy` now raises a `TypeError` for the keyword
+arguments 'interpolation', 'extent' and 'linestyle' instead of silently
+ignoring them.
diff --git a/lib/matplotlib/axes/_axes.py b/lib/matplotlib/axes/_axes.py
@@ -7360,6 +7360,10 @@ def spy(self, Z, precision=0, marker=None, markersize=None,
                                                         name='binary')
             nr, nc = Z.shape
             extent = [-0.5, nc - 0.5, nr - 0.5, -0.5]
+            for kw in ['interpolation', 'extent']:
+                if kw in kwargs:
+                    raise TypeError(
+                        "spy() got an unexpected keyword argument '%s'" % kw)
             ret = self.imshow(mask, interpolation='nearest', aspect=aspect,
                                 extent=extent, origin=origin, **kwargs)
         else:
@@ -7380,6 +7384,9 @@ def spy(self, Z, precision=0, marker=None, markersize=None,
                 marker = 's'
             if markersize is None:
                 markersize = 10
+            if 'linestyle' in kwargs:
+                raise TypeError(
+                    "spy() got an unexpected keyword argument 'linestyle'")
             marks = mlines.Line2D(x, y, linestyle='None',
                          marker=marker, markersize=markersize, **kwargs)
             self.add_line(marks)
