Make add_element more general, and make sure the code complies with it.

OceanWolf · tacaswell · commit ebf0c57abf69 · 2017-06-19T00:33:02.000-04:00
diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py
@@ -2701,7 +2701,7 @@ def set_window_title(self, title):
         """
         pass
 
-    def add_element_to_window(self, element, expand, fill, padding, from_start=False):
+    def add_element_to_window(self, element, expand, fill, pad, side='bottom'):
         """ Adds a gui widget to the window.
         This has no effect for non-GUI backends
         """
diff --git a/lib/matplotlib/backend_managers.py b/lib/matplotlib/backend_managers.py
@@ -46,12 +46,12 @@ def __init__(self, figure, num):
         w = int(self.canvas.figure.bbox.width)
         h = int(self.canvas.figure.bbox.height)
 
-        self.window.add_element_to_window(self.canvas, True, True, 0, True)
+        self.window.add_element_to_window(self.canvas, True, True, 0, 'top')
 
         self.toolbar = self._get_toolbar()
         if self.toolbar is not None:
             h += self.window.add_element_to_window(self.toolbar,
-                                                   False, False, 0)
+                                                   False, False, 0, 'bottom')
 
         self.window.set_default_size(w, h)
 
diff --git a/lib/matplotlib/backends/backend_gtk3.py b/lib/matplotlib/backends/backend_gtk3.py
@@ -395,15 +395,17 @@ def __init__(self, title):
         self.window.add(self.vbox)
         self.vbox.show()
 
-        self.window.connect('destroy', self.destroy_event) # TODO create in base
+        self.window.connect('destroy', self.destroy_event)
         self.window.connect('delete_event', self.destroy_event)
 
-    def add_element_to_window(self, element, expand, fill, padding, from_start=False):
+    def add_element_to_window(self, element, expand, fill, pad, side='bottom'):
         element.show()
-        if from_start:
-            self.vbox.pack_start(element, expand, fill, padding)
+        if side == 'top':
+            self.vbox.pack_start(element, expand, fill, pad)
+        elif side == 'bottom':
+            self.vbox.pack_end(element, expand, fill, pad)
         else:
-            self.vbox.pack_end(element, False, False, 0)
+            raise KeyError('Unknown value for side, %s' % side)
         size_request = element.size_request()
         return size_request.height
 
