Convert units when returning Rect bbox

dstansby · dstansby · commit f40607e20675 · 2017-12-03T12:07:06.000Z
diff --git a/lib/matplotlib/patches.py b/lib/matplotlib/patches.py
@@ -687,10 +687,7 @@ def _update_patch_transform(self):
                  makes it very important to call the accessor method and
                  not directly access the transformation member variable.
         """
-        x0 = self.convert_xunits(self._x0)
-        y0 = self.convert_yunits(self._y0)
-        x1 = self.convert_xunits(self._x1)
-        y1 = self.convert_yunits(self._y1)
+        x0, y0, x1, y1 = self._convert_units()
         bbox = transforms.Bbox.from_extents(x0, y0, x1, y1)
         rot_trans = transforms.Affine2D()
         rot_trans.rotate_deg_around(x0, y0, self.angle)
@@ -703,6 +700,16 @@ def _update_x1(self):
     def _update_y1(self):
         self._y1 = self._y0 + self._height
 
+    def _convert_units(self):
+        '''
+        Convert bounds of the rectangle
+        '''
+        x0 = self.convert_xunits(self._x0)
+        y0 = self.convert_yunits(self._y0)
+        x1 = self.convert_xunits(self._x1)
+        y1 = self.convert_yunits(self._y1)
+        return x0, y0, x1, y1
+
     def get_patch_transform(self):
         self._update_patch_transform()
         return self._rect_transform
@@ -720,7 +727,7 @@ def get_xy(self):
         return self._x0, self._y0
 
     def get_width(self):
-        "Return the width of the  rectangle"
+        "Return the width of the rectangle"
         return self._width
 
     def get_height(self):
@@ -797,6 +804,7 @@ def set_bounds(self, *args):
         self.stale = True
 
     def get_bbox(self):
+        x0, y0, x1, y1 = self._convert_units()
         return transforms.Bbox.from_extents(self._x0, self._y0,
                                             self._x1, self._y1)
 
