(1) turn off the grid after creating colorbar axes (2) added a test

pharshalp · pharshalp · commit f6a54ab8e185 · 2022-01-13T16:24:24.000-05:00
diff --git a/lib/matplotlib/tests/test_colorbar.py b/lib/matplotlib/tests/test_colorbar.py
@@ -1,6 +1,5 @@
 import numpy as np
 import pytest
-import warnings
 
 from matplotlib import cm
 import matplotlib.colors as mcolors
@@ -941,15 +940,13 @@ def test_boundaries():
     cb = fig.colorbar(pc, ax=ax, boundaries=np.linspace(-3, 3, 7))
 
 
-def test_colorbar_no_warning():
+def test_colorbar_no_warning_rcparams_grid_true():
     # github issue #21723 - If mpl style has 'axes.grid' = True,
     # fig.colorbar raises a warning about Auto-removal of grids
     # by pcolor() and pcolormesh(). This is fixed by PR #22216.
-    with warnings.catch_warnings(record=True) as w:
-        plt.rcParams['axes.grid'] = True
-        fig, ax = plt.subplots()
-        ax.grid(False)
-        im = ax.pcolormesh([0, 1], [0, 1], [[1]])
-        fig.colorbar(im)
-    # make sure that no warning is raised
-    assert len(w) == 0
+    plt.rcParams['axes.grid'] = True
+    fig, ax = plt.subplots()
+    ax.grid(False)
+    im = ax.pcolormesh([0, 1], [0, 1], [[1]])
+    # make sure that no warning is raised by fig.colorbar
+    fig.colorbar(im)
