Fix issue with locale comma when not using math text

oscargus · oscargus · commit f923a8a91ec3 · 2023-09-18T11:09:48.000+02:00
diff --git a/lib/matplotlib/tests/test_ticker.py b/lib/matplotlib/tests/test_ticker.py
@@ -1654,6 +1654,11 @@ def _impl_locale_comma():
     fmt = ',$\\mathdefault{,%1.1f},$'
     x = ticks._format_maybe_minus_and_locale(fmt, 0.5)
     assert x == ',$\\mathdefault{,0{,}5},$'
+    # Make sure no brackets are added if not using math text
+    ticks = mticker.ScalarFormatter(useMathText=False, useLocale=True)
+    fmt = '%1.1f'
+    x = ticks._format_maybe_minus_and_locale(fmt, 0.5)
+    assert x == '0,5'
 
 
 def test_locale_comma():
diff --git a/lib/matplotlib/ticker.py b/lib/matplotlib/ticker.py
@@ -516,11 +516,11 @@ def _format_maybe_minus_and_locale(self, fmt, arg):
         Format *arg* with *fmt*, applying Unicode minus and locale if desired.
         """
         return self.fix_minus(
-                # Escape commas introduced by format_string but not those present
-                # from the beginning in fmt.
-                ",".join(locale.format_string(part, (arg,), True)
-                         .replace(",", "{,}")
-                         for part in fmt.split(","))
+                # Escape commas introduced by locale.format_string if using math text,
+                # but not those present from the beginning in fmt.
+                (",".join(locale.format_string(part, (arg,), True).replace(",", "{,}")
+                          for part in fmt.split(",")) if self._useMathText
+                 else locale.format_string(fmt, (arg,), True))
                 if self._useLocale
                 else fmt % arg)
 
