Skip to content

warnings re: deprecated pytest API with pytest 3.8 #12107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anntzer opened this issue Sep 13, 2018 · 1 comment · Fixed by #12154
Closed

warnings re: deprecated pytest API with pytest 3.8 #12107

anntzer opened this issue Sep 13, 2018 · 1 comment · Fixed by #12154
Labels
topic: testing
Milestone
v3.1.0

Comments

@anntzer
Copy link
Contributor

anntzer commented Sep 13, 2018

Running the test suite on master with pytest 3.8 gives a bunch of pytest internal warnings:

/home/antony/src/extern/matplotlib/lib/matplotlib/testing/conftest.py:37: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  assert len(style_marker.args) == 1, \
/home/antony/src/extern/matplotlib/lib/matplotlib/testing/conftest.py:39: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  style = style_marker.args[0]
/home/antony/src/extern/matplotlib/lib/matplotlib/testing/conftest.py:67: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  baseline_images = request.keywords['baseline_images'].args[0]

@QuLogic looks like you wrote some of this (#7973), pinging you just in case you know how to update it :)

Note that we didn't see this on CI because CI uses pytest-xdist and the latter suppresses internal warnings (pytest-dev/pytest-xdist#338)...

I guess it would be moderately nice to fix this in 3.0 but it's certainly not release critical.
@anntzer anntzer added this to the v3.0 milestone Sep 13, 2018
@tacaswell tacaswell modified the milestones: v3.0, v3.1 Sep 15, 2018
@tacaswell
Copy link
Member

Moving to 3.1 for book keeping reasons, may re-milestone back to 3.0.x once that milestone exists.

@anntzer anntzer mentioned this issue Sep 18, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

Avoid triggering deprecation warnings with pytest 3.8. anntzer/matplotlib
2 participants
@tacaswell @anntzer