Skip to content

Tests errors related to 'MarkDecorator' #13182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ArchangeGabriel opened this issue Jan 14, 2019 · 4 comments
Closed

Tests errors related to 'MarkDecorator' #13182

ArchangeGabriel opened this issue Jan 14, 2019 · 4 comments
Labels
topic: testing
Milestone
v2.2.4

Comments

@ArchangeGabriel
Copy link
Contributor

Bug report

Bug summary

During ArchLinux packaging builds, we have a bunch of errors related to 'MarkDecorator'.

Three different errors:

E TypeError: object of type 'MarkDecorator' has no len()
E AttributeError: 'MarkDecorator' object has no attribute 'encode'
E TypeError: cannot concatenate 'str' and 'MarkDecorator' objects

that lead to think it is supposed to be a string but actually is not.

Full log (minus irrelevant ImageComparisonFailure: images not close due to fonts/freetype2 differences) available here: https://paste.xinu.at/KRdO/

Likely yet another pytest issue?

Matplotlib version
@tacaswell tacaswell added this to the v2.2.4 milestone Jan 14, 2019
@ArchangeGabriel
Copy link
Contributor Author

Could be related to https://github.com/matplotlib/matplotlib/pull/12297/files, will try to backport the changes locally and see what it gives.

@ArchangeGabriel ArchangeGabriel mentioned this issue Jan 14, 2019
Merged
@ArchangeGabriel
Copy link
Contributor Author

ArchangeGabriel commented Jan 16, 2019 •
edited
Loading

First twos (which were ERRORS, not FAILURES) are indeed solved by backporting #12297. The last one, which is a FAILURE, still remains though:

________________________ test_mixedsubplots[extension2] ________________________
[gw4] linux2 -- Python 2.7.15 /usr/bin/python2

self = <matplotlib.testing.decorators._ImageComparisonBase object at 0x7fcc0038d5d0>
idx = 0, baseline = 'mixedsubplot'
extension = MarkDecorator(mark=Mark(name='xfail', args=('svg',), kwargs={'strict': False}))

    def compare(self, idx, baseline, extension):
        __tracebackhide__ = True 
        fignum = plt.get_fignums()[idx]
        fig = plt.figure(fignum)
    
        if self.remove_text:
            remove_ticks_and_titles(fig)
    
        actual_fname = (
>           os.path.join(self.result_dir, baseline) + '.' + extension)
E       TypeError: cannot concatenate 'str' and 'MarkDecorator' objects

lib/matplotlib/testing/decorators.py:284: TypeError

Interestingly, this is the only test showing this error in our builds, while in #13181 they are a lot of them.

EDIT: The multiple failures in #13181 AppVeyor are due to image comparison tests being skipped (instead of properly run in the other builds), and skipping failing (but likely for the same reason as here).

@ArchangeGabriel
Copy link
Contributor Author

Should be fixed by 13bde8f + bd7e729.

@ArchangeGabriel
Copy link
Contributor Author

Confirmed on the ArchLinux build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v2.2.4
Development

No branches or pull requests
3 participants
@tacaswell @ArchangeGabriel @dstansby