-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Examples that use private APIs #13199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For axes_grid I think we should consider how to make that a core functionality. |
Refs matplotlib#13199; all but the last are fixed.
The last example seems to exist solely to derive from that private API, so I don't know what to do about it. |
Perhaps that base class should be made public, if we want to support this kind of addition of BoxStyles. |
As written elsewhere, I have doubts that private base classes are a reasonable approach. Their code leaks into the child classes, which is intended, but OTOH confusing because you're not seeing the base class. This also messes up sphinx because the inherited methods are not documented and cannot be linked. Generally, I cannot remember to have seen private base classes anywhere else. I feel it's better to make the base class public, but some of it's members private or abstract. |
Note, as part of #16615, the last example was merged into https://github.com/matplotlib/matplotlib/blob/master/examples/userdemo/custom_boxstyle01.py though the private API is still used. |
I have an idea of how to get rid of that private base class (essentially, move the mutation aspect handling out of |
The following examples rely on at least one private API. They should be changed to not use the private API, or, if that's not possible, we should discuss how to make that API public.
Fixed in #13202:
https://github.com/matplotlib/matplotlib/blob/master/examples/axes_grid1/demo_axes_grid2.pyhttps://github.com/matplotlib/matplotlib/blob/master/examples/axisartist/demo_curvelinear_grid2.pyhttps://github.com/matplotlib/matplotlib/blob/master/examples/axisartist/demo_floating_axes.pyhttps://github.com/matplotlib/matplotlib/blob/master/examples/axisartist/demo_parasite_axes.pyStill need fixing:
https://github.com/matplotlib/matplotlib/blob/master/examples/userdemo/custom_boxstyle02.pyis now the second example of https://matplotlib.org/devdocs/gallery/userdemo/custom_boxstyle01.html
The text was updated successfully, but these errors were encountered: