Skip to content

Tests files installed by default? #13993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArchangeGabriel opened this issue Apr 20, 2019 · 9 comments
Closed

Tests files installed by default? #13993

ArchangeGabriel opened this issue Apr 20, 2019 · 9 comments
Milestone

Comments

@ArchangeGabriel
Copy link
Contributor

I’ve just tried to compile from the 3.1.0rc1 tag for ArchLinux to see if everything runs OK, but I’ve noticed that the large bunch of tests files (usr/lib/python3.7/site-packages/matplotlib/tests/, usr/lib/python3.7/site-packages/matplotlib/sphinxext/tests/ and usr/lib/python3.7/site-packages/mpl_toolkits/tests/) got installed while we don’t have any specific setup.cfg, so that tests should not be installed as is the default (and has been for the past years/releases).

I can provide more information if required, just tell me what (and eventually where to look for them).

@tacaswell tacaswell added this to the v3.1.0 milestone Apr 20, 2019
@tacaswell
Copy link
Member

Thanks for testing for looking at the rc!

It looks like this was intentially changed in fc73b77 / #12317 . We pinged @felixonmars for Arch but got no response.

@felixonmars
Copy link
Contributor

Sorry for being inactive on that issue. Since Arch don't split packages I tend to provide mostly the default set. I didn't notice the tests installation change.

@ArchangeGabriel
Copy link
Contributor Author

@tacaswell What I’m saying is that matplotlib install now defaults to tests = True, while still saying the opposite. It might be a side-effect of the linked changes, but likely not the intended behaviour. I’ll look at those files and see if I find something weird.

@ArchangeGabriel
Copy link
Contributor Author

OK, indeed: https://github.com/matplotlib/matplotlib/pull/12317/files#diff-c28358ce9623af21f7b6e068f69085b7R662

I don’t think this was intended, am I right?

@tacaswell
Copy link
Member

I think that was an intended change, but we failed to update the documentation / template. Is that going to be a problem for Arch?

@anntzer can you confirm the intent?

Also, thank you to both @ArchangeGabriel and @felixonmars for your work on Arch packaging 🎉 (it is what I use on my personal machines).

@ArchangeGabriel
Copy link
Contributor Author

No, it won’t be an issue at all, we build two copies anyway (one with the tests to check everything but fonts work, one without the tests for distribution). So currently the two copies end up being identical, but if it gets confirmed that this was intended, then we will switch from enabling tests in one copy to disabling them in the other. ;)

@anntzer
Copy link
Contributor

anntzer commented Apr 23, 2019

Always installing tests was not an intended change of that PR (in fact as @tacaswell may remember I have a PR in the works for splitting the test install even more), looks like it got in accidentally... making a PR to revert that.
Edit: #14008.

@timhoffm
Copy link
Member

Reverted in #14008

@tacaswell
Copy link
Member

in fact as @tacaswell may remember I have a PR in the works for splitting the test install even more

No, my memory is a bit sieve like....

Thanks for following up on thin @anntzer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants