Skip to content

forward port jquery removal from ipympl #14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tacaswell opened this issue Jun 21, 2019 · 3 comments · Fixed by #17053
Closed

forward port jquery removal from ipympl #14596

tacaswell opened this issue Jun 21, 2019 · 3 comments · Fixed by #17053
Assignees
@QuLogic
Labels
GUI: webagg
Milestone
v3.3.0

Comments

@tacaswell
Copy link
Member

matplotlib/ipympl#85 removes jquery from ipympl. Much of that js is shared / derived from the webagg and nbagg backends currently shipped in Matplotlib.

Going forward we should pull that patch forward (probably not for old version so it won't help us with #14587 and friends) and deprecate the nbagg backend (as it does not work with jlab) but keep the webagg backend.
@tacaswell tacaswell added this to the v3.2.0 milestone Jun 21, 2019
@timhoffm timhoffm mentioned this issue Jun 23, 2019
Closed
@jklymak
Copy link
Member

jklymak commented Jun 24, 2019

I'm not a fan of deprecating nbagg until matplotlib/ipympl#16 is closed.

@tacaswell tacaswell modified the milestones: v3.2.0, v3.3.0 Sep 1, 2019
@QuLogic QuLogic self-assigned this Apr 4, 2020
@QuLogic
Copy link
Member

QuLogic commented Apr 4, 2020

Do we want to support IE 8, 9, or 10?

@timhoffm
Copy link
Member

timhoffm commented Apr 5, 2020

Jupyter notebook and Jupyterlab both don't support IE:
https://jupyter-notebook.readthedocs.io/en/stable/notebook.html#browser-compatibility
https://jupyterlab.readthedocs.io/en/stable/getting_started/installation.html#supported-browsers

Therefore I don't think it's necessary that we support IE.

QuLogic added a commit to QuLogic/matplotlib that referenced this issue Apr 7, 2020
@QuLogic
Replace jquery by vanilla JS.
4218685 
This is a mix of the change in ipympl, plus the same thing for our
original version of other stuff.

Fixes matplotlib#14596.
@QuLogic QuLogic mentioned this issue Apr 7, 2020
Merged
1 task
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Apr 14, 2020
@QuLogic
Replace jquery by vanilla JS.
2fbd582 
This is a mix of the change in ipympl, plus the same thing for our
original version of other stuff.

Fixes matplotlib#14596.
QuLogic added a commit to QuLogic/matplotlib that referenced this issue Apr 25, 2020
@QuLogic
Replace jquery by vanilla JS.
5356ef0 
This is a mix of the change in ipympl, plus the same thing for our
original version of other stuff.

Fixes matplotlib#14596.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@QuLogic QuLogic

Labels
GUI: webagg
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging a pull request may close this issue.

Replace most jQuery with vanilla JavaScript QuLogic/matplotlib
4 participants
@tacaswell @QuLogic @jklymak @timhoffm