Skip to content

Cleanup Artist.draw() signatures #16022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timhoffm opened this issue Dec 25, 2019 · 0 comments · Fixed by #16063
Closed

Cleanup Artist.draw() signatures #16022

timhoffm opened this issue Dec 25, 2019 · 0 comments · Fixed by #16063
Labels
API: consistency Maintenance
Milestone
v3.3.0

Comments

@timhoffm
Copy link
Member

As discussed in ##16010: Artist.draw() and its subclasses should have identical or similar signatures.

  • Default should be def draw(self, renderer) - remove *args, **kwargs.
  • Check if we need the inframe kwarg used in some subclasses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API: consistency Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging a pull request may close this issue.

Make the signature of Axes.draw() consistent with Artist.draw(). anntzer/matplotlib
2 participants
@QuLogic @timhoffm