Skip to content

Expose internal animation parameters #17928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
story645 opened this issue Jul 15, 2020 · 1 comment
Open

Expose internal animation parameters #17928

story645 opened this issue Jul 15, 2020 · 1 comment
Labels
Documentation: API files in lib/ and doc/api topic: animation

Comments

@story645
Copy link
Member

To follow up on this, the current call to HTMLWriter only passes three arguments:

matplotlib/lib/matplotlib/animation.py

Lines 1359 to 1361 in 6b2cecc

writer = HTMLWriter(fps=fps,
embed_frames=embed_frames,
default_mode=default_mode)

but there are several more parameters that it could set:

matplotlib/lib/matplotlib/animation.py

Lines 796 to 798 in 6b2cecc

def __init__(self, fps=30, codec=None, bitrate=None, extra_args=None,
metadata=None, embed_frames=False, default_mode='loop',
embed_limit=None):

So we could thread through the frame_format parameter in this PR, but I think it might be better handled in a separate PR that focuses entirely on exposing internal animation parameters. This I think is independent of the issue in this thread, where the rcParams does not allow us to set a default at all currently. Fixing the rcparams check (#17909 ) seems necessary to me, exposing more API seems nice-to-have.

Originally posted by @bmcfee in #17908 (comment)
@github-actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Aug 11, 2023
@story645 story645 added Documentation: API files in lib/ and doc/api and removed status: inactive Marked by the “Stale” Github Action labels Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation: API files in lib/ and doc/api topic: animation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@story645