Skip to content

different behaviour between 3.3.0 and 3.2.2 (and earlier) for ploting in a Tk canvas #18232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yevgenyr opened this issue Aug 12, 2020 · 3 comments · Fixed by #18235
Closed

different behaviour between 3.3.0 and 3.2.2 (and earlier) for ploting in a Tk canvas #18232

yevgenyr opened this issue Aug 12, 2020 · 3 comments · Fixed by #18235
Milestone
v3.3.1

Comments

@yevgenyr
Copy link

Bug report

I am trying to plot graphs in a Tk canvas, and I find different behavior for mpl 3.3.0 and 3.2.2.
I am running the same code:

The code I am reusing it from here: https://github.com/SuperMechaDeathChrist/Widgets/blob/master/plt_figure_w_controls.py

it runs well for 3.2.2 and bellow but get the following error for 3.3.0:

Traceback (most recent call last):
  File "/home/yr2369/dev/mosydb/_personal/tests/plt_sg.py", line 90, in <module>
    'fig_cv').TKCanvas, fig, window.FindElement('controls_cv').TKCanvas)
  File "/home/yr2369/dev/mosydb/_personal/tests/plt_sg.py", line 17, in draw_figure_w_toolbar
    toolbar = Toolbar(figure_canvas_agg, canvas_toolbar)
  File "/home/yr2369/dev/mosydb/_personal/tests/plt_sg.py", line 34, in __init__
    super(Toolbar, self).__init__(*args, **kwargs)
  File "/home/yr2369/anaconda3/envs/mosydb/lib/python3.7/site-packages/matplotlib/backends/_backend_tk.py", line 525, in __init__
    NavigationToolbar2.__init__(self, canvas)
  File "/home/yr2369/anaconda3/envs/mosydb/lib/python3.7/site-packages/matplotlib/backend_bases.py", line 2866, in __init__
    self.set_history_buttons()
  File "/home/yr2369/anaconda3/envs/mosydb/lib/python3.7/site-packages/matplotlib/backends/_backend_tk.py", line 640, in set_history_buttons
    self._buttons['Back']['state'] = tk.DISABLED
KeyError: 'Back'

Process finished with exit code 1

It looks like an easy fix, but maybe I am wrong - let me know what additional details you need from me.
I use python 3.7.8
ps - to test the code - pip install pysimplegui

Thank you
@tacaswell tacaswell added this to the v3.3.1 milestone Aug 12, 2020
@tacaswell
Copy link
Member

It looks like in 56504fa we made sure that we updated the active/inactive state of the history buttons in Tk, but that sub-class is removing them all together so they are not there to update.

@QuLogic
Copy link
Member

QuLogic commented Aug 12, 2020

Should be a simple fix to handle this like Qt does:

matplotlib/lib/matplotlib/backends/backend_qt5.py

Lines 822 to 828 in 4ac49b9

def set_history_buttons(self):
can_backward = self._nav_stack._pos > 0
can_forward = self._nav_stack._pos < len(self._nav_stack._elements) - 1
if 'back' in self._actions:
self._actions['back'].setEnabled(can_backward)
if 'forward' in self._actions:
self._actions['forward'].setEnabled(can_forward)

@tacaswell
Copy link
Member

I'll have a PR shortly.

tacaswell added a commit to tacaswell/matplotlib that referenced this issue Aug 12, 2020
@tacaswell
FIX: check we have a back button in tk toolbar before we touch it
6bf545e 
We add one by default, but sub-classes may remove it.

closes matplotlib#18232
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Aug 12, 2020
@tacaswell
FIX: check we have a back button in tk toolbar before we touch it
f2b870e 
We add one by default, but sub-classes may remove it.

closes matplotlib#18232
@tacaswell tacaswell mentioned this issue Aug 12, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging a pull request may close this issue.

FIX: check we have a back button in tk toolbar before we touch it tacaswell/matplotlib
3 participants
@tacaswell @QuLogic @yevgenyr