Skip to content

Improve GitHub labels #18855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timhoffm opened this issue Oct 31, 2020 · 3 comments
Closed

Improve GitHub labels #18855

timhoffm opened this issue Oct 31, 2020 · 3 comments

Comments

@timhoffm
Copy link
Member

As discussed some time ago on the dev call, we need better GitHub labels to manage issues and PRs.

I don't think we'll manage to rebuild labels from scratch (or if we do, that it would be the perfect system). Therefore I propose to incrementally evolve the labels.

I've collected all present labels in a google spreadsheet

I did a rough classification:

  • State: Something to do with "next action"
  • Topic: Which part of matplotlib does it address?
  • Scope: This is only sort of a collection of non-state non-topic labels. One might split or rename this, but it's currently not my focus.

For now, I'm focussing on State, because the notion of "next action" has been identified to be important (c.f. https://hackmd.io/P3Hrfoy9RSKRA4-mXMKW2A#PR-closing-philosophy).

I propose the following:

  • Rename all state labels label name to state: label name.
    Rationale: The prefix distinguishes these labels from other classes (which may or may not grow a prefix themselves later on).
  • Change the colors to a simple 4-color scheme based on who must do the next action to move the issue/PR forward:
    grafik
    Rationale: By this coloring we can immediately see whether the issue/PR needs an action from our side, which is the most important aspect for issue management. IMO the 4 colors are enough. One could add slight variations, e.g. different greys for different "no action" labels, but then again, nobody will exactly remember these. So let's keep it simple for a start. We can still refine this later if needed.
@story645
Copy link
Member

story645 commented Nov 1, 2020

I like this plan, and we should probably recolor anything else that uses these colors to something else so there's no conflict.
(also we should consolidate the MEPs to MEP: #)

@timhoffm
Copy link
Member Author

timhoffm commented Nov 3, 2020

  • Renamed and recolored all status labels.
  • Recolored some other labels that used one of the above colors.

@timhoffm timhoffm closed this as completed Nov 3, 2020
@QuLogic
Copy link
Member

QuLogic commented Nov 11, 2020

FYI, 'Still Needs Manual Backport' is added by the bot, and so your rename and re-color of it didn't have any effect (cf #18929).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants