-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Singular keyword arguments in contour don't raise exceptions #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note that, whatever solution is implemented, we'd have to do this for all the plotting routines that take plural kwargs. |
Consistency concern is valid for more than just contour, see the api doc for pyplot http://matplotlib.org/api/pyplot_api.html
and others, I'm sure Will require deciding combinations to keep and applying consistently across all. The easiest would be to just take the union of all the currently valid variants across methods for a particular keyword (e.g., I recommend labeling with Difficulty: Medium and Documentation |
See also #2369 for thoughts on what to do with extra (though not typo'd) keyword arguments. |
This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help! |
I think this is still a valid concern. Probably requires some discussion, however I'd be in favour of aliasing these |
Now that ContourSet has been modified to actually be an artist, we should just route most kwargs to Artist.set() and let that handle standard aliases and error out as usual on unknown properties. |
I have confused myself several times (and have seen it happen many times with other people) by something like this not working, but also not raising a warning or exception:
The fact that the keywords are not plural in this case is quite pedantic, but the real issue is that there are not even any warnings or errors, so users are left having no idea why this doesn't work, and are left frustrated when they do find out.
So I would suggest either:
The text was updated successfully, but these errors were encountered: